Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Custom sorting by message level on Notifications page #153462

Merged
merged 11 commits into from
Mar 27, 2023
Merged

[ML] Custom sorting by message level on Notifications page #153462

merged 11 commits into from
Mar 27, 2023

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Mar 22, 2023 •
edited
Loading

Summary

Part of #143034

Adds custom sorting for the notification level.

  • For descending sorting: error -> warning -> info
  • For ascending sorting: info -> warning -> error

image

Checklist

@darnautov darnautov assigned daixque and darnautov and unassigned daixque Mar 22, 2023
@darnautov darnautov force-pushed the ml-143034-custom-sort branch from 197bafd to c758684 Compare March 23, 2023 17:59
@darnautov darnautov mentioned this pull request Mar 24, 2023
Closed
@darnautov darnautov force-pushed the ml-143034-custom-sort branch from 4eb4252 to d394a9d Compare March 24, 2023 16:06
@darnautov darnautov marked this pull request as ready for review March 24, 2023 16:08
@darnautov darnautov requested a review from a team as a code owner March 24, 2023 16:08
@darnautov darnautov added :ml Team:ML Team label for ML (also use :ml) v8.8.0 labels Mar 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov requested a review from qn895 March 27, 2023 08:17
@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Mar 27, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #1 / when migrating to a new version and the mappings' changes are still compatible the migrator skips reindexing

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB +107.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB +107.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@peteharverson peteharverson mentioned this pull request Mar 27, 2023
Closed
7 tasks
peteharverson
peteharverson approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@qn895
Copy link
Member

qn895 commented Mar 27, 2023 •
edited
Loading

Tested latest changes and LGTM 🎉

@darnautov darnautov merged commit 04ed17d into elastic:main Mar 27, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 27, 2023
@darnautov darnautov deleted the ml-143034-custom-sort branch March 27, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@darnautov darnautov

Labels
backport:skip This commit does not require backporting :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@darnautov @elasticmachine @kibana-ci @qn895 @peteharverson @daixque @kibanamachine