-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate ruby environment and set java heap size #1533
Conversation
Testing this - failed. Currently fails loading puma/puma_http11 but this file is a shared object (?) under here. Which is weird. I"m looking into how this got built so I can fix it.
|
I seem to have resolved my build problem by having the environment ruby be jruby during Either way, here's test results:
|
Yeah probably expected, since your system ruby is probably 2.1.x and jruby is 1.9.3 and thy probably don't share gems and such. We'll check out the pull! |
export GEM_HOME= | ||
export GEM_PATH= | ||
|
||
KIBANA_VERSIO=@@version CONFIG_PATH=${DIR}/../config/kibana.yml RACK_ENV=production exec "${JAVA}" $JAVA_OPTS -jar "${DIR}/../lib/kibana.jar" "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here? KIBANA_VERSION => KIBANA_VERSIO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
facepalm
* Clear GEM_HOME and GEM_PATH variables to ensure we are only using the gems baked into the kibana jar and don't accidentally use the user/system's gem paths (Fixes #1531) * Set JVM heap size to 512m. If we don't do this, the default (for the common JVMs) is 25% of system ram, which is not a desirable default.
Fixed and repushed as a single commit. |
I tried to test this, but I couldn't get the reported error to happen, no matter what local version of ruby I installed, so I couldn't verify that it goes away |
Isolate ruby environment and set java heap size
the gems baked into the kibana jar and don't accidentally use
the user/system's gem paths (Fixes Mixed ruby environment makes bin/kibana fail to load puma #1531)
common JVMs) is 25% of system ram, which is not a desirable default.