Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] baseline kibana api tests for package and metricbeat data #153184

Merged
merged 10 commits into from
Mar 20, 2023
Merged

[Stack Monitoring] baseline kibana api tests for package and metricbeat data #153184

merged 10 commits into from
Mar 20, 2023

Conversation

klacabane
Copy link
Contributor

@klacabane klacabane commented Mar 13, 2023 •
edited
Loading

Summary

Part of #148303

Port kibana api tests to the monitoring_api_integration suite. This reimplements all the existing tests with fresh data.

See flaky test run

@klacabane klacabane mentioned this pull request Mar 13, 2023
Closed
5 tasks
@klacabane klacabane self-assigned this Mar 14, 2023
@klacabane klacabane added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes Feature:Stack Monitoring backport:skip This commit does not require backporting labels Mar 14, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @klacabane

@klacabane klacabane marked this pull request as ready for review March 14, 2023 16:33
@klacabane klacabane requested a review from a team as a code owner March 14, 2023 16:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

miltonhultgren
miltonhultgren approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@klacabane klacabane merged commit e1579c8 into elastic:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miltonhultgren miltonhultgren miltonhultgren approved these changes

Assignees

@klacabane klacabane

Labels
backport:skip This commit does not require backporting Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@klacabane @kibana-ci @elasticmachine @miltonhultgren @kibanamachine