Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.7] [Synthetics] handle onboarding for onprem deployments (#152048) #153163

Merged
merged 5 commits into from
Mar 13, 2023

Conversation

dominiqueclarke
Copy link
Contributor

Backport

This will backport the following commits from main to 8.7:

Questions ?

Please refer to the Backport tool documentation

## Summary

Directs on-prem users to create a private location, before allowing
on-prem users to create monitors.

Admin user
[Monitor-Management-Synthetics---Kibana
(6).webm](https://user-images.githubusercontent.com/11356435/222554184-3f399764-0c3d-41e4-9652-7ec5616a320c.webm)

User without Fleet privileges
[Synthetics-Getting-Started-Synthetics---Kibana
(3).webm](https://user-images.githubusercontent.com/11356435/222554216-893a9a79-a152-459d-b6e6-d5bdfc5014dc.webm)

### Testing

1. Start ES with yarn es snapshot
2. Remove all `xpack.uptime.service` configs in your Kibana.dev.yml
3. Start Kibana connected to local ES
4. Navigate to Synthetics and enable monitor
5. Confirm that Add monitor flow appears first before creating a monitor

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: shahzad31 <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
(cherry picked from commit 01ba027)

# Conflicts:
#	x-pack/plugins/synthetics/public/apps/synthetics/utils/testing/rtl_helpers.tsx
@dominiqueclarke dominiqueclarke enabled auto-merge (squash) March 12, 2023 19:48
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Mar 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstrea

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.4MB 1.4MB +3.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
synthetics 26.6KB 26.6KB +66.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit 21c8d91 into elastic:8.7 Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants