Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: cleanup saved object mapping #153139

Merged
merged 8 commits into from
Mar 27, 2023
Merged

url: cleanup saved object mapping #153139

merged 8 commits into from
Mar 27, 2023

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Mar 10, 2023 •
edited
Loading

Summary

Related to #149102

Subset of the global cleanup attempt in #153070

Dry run for cleaning up url mappings

@TinaHeiligers TinaHeiligers added Feature:SharingURLs Short URLs and Share URL features release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.8.0 labels Mar 10, 2023
@TinaHeiligers
Copy link
Contributor Author

@elastic/appex-sharedux if CI goes green, we can use this PR to clean up the url mappings.
If not, it means there's a direct reference to the fields and you'll need to decide how to handle that.
I'm aware of the migration that directly refers to locatorJSON, that you'll probably want to update/handle/change.

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers marked this pull request as ready for review March 16, 2023 14:20
@TinaHeiligers TinaHeiligers requested review from a team as code owners March 16, 2023 14:20
vadimkibana
vadimkibana requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@vadimkibana vadimkibana left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing locatorJSON will break short URLs. Setting dynamic: false, LGTM.

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vadimkibana vadimkibana mentioned this pull request Mar 27, 2023
Closed
6 tasks
@TinaHeiligers TinaHeiligers merged commit a5bf13f into elastic:main Mar 27, 2023
@TinaHeiligers TinaHeiligers deleted the url-cleanup-index-false branch March 28, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadimkibana vadimkibana vadimkibana approved these changes

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:SharingURLs Short URLs and Share URL features release_note:skip Skip the PR/issue when compiling release notes v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TinaHeiligers @kibana-ci @jloleysens @vadimkibana @kibanamachine