Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Response Ops][Alerting] Reusable functions for FAAD resource installation #152849

Merged
merged 4 commits into from
Mar 20, 2023
Merged

[Response Ops][Alerting] Reusable functions for FAAD resource installation #152849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60ef606
Extract alert service methods into helper functions and reusing them …
ymao1 Mar 8, 2023
3c46ed8
Merge branch 'main' of github.com:elastic/kibana into alerting/faad-r…
ymao1 Mar 9, 2023
9faecef
Merge branch 'main' of github.com:elastic/kibana into alerting/faad-r…
ymao1 Mar 10, 2023
75956a0
Merge branch 'main' into alerting/faad-resources-preview
kibanamachine Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions x-pack/plugins/alerting/server/alerts_service/alerts_service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,18 +58,16 @@ const GetAliasResponse = {
};

const IlmPutBody = {
body: {
policy: {
_meta: {
managed: true,
},
phases: {
hot: {
actions: {
rollover: {
max_age: '30d',
max_primary_shard_size: '50gb',
},
policy: {
_meta: {
managed: true,
},
phases: {
hot: {
actions: {
rollover: {
max_age: '30d',
max_primary_shard_size: '50gb',
},
},
},
Expand Down Expand Up @@ -212,7 +210,6 @@ describe('Alerts Service', () => {
);

expect(clusterClient.ilm.putLifecycle).toHaveBeenCalled();
expect(clusterClient.cluster.putComponentTemplate).not.toHaveBeenCalled();
});

test('should log error and set initialized to false if creating/updating common component template throws error', async () => {
Expand All @@ -232,7 +229,6 @@ describe('Alerts Service', () => {
);

expect(clusterClient.ilm.putLifecycle).toHaveBeenCalled();
expect(clusterClient.cluster.putComponentTemplate).toHaveBeenCalledTimes(1);
});

test('should update index template field limit and retry initialization if creating/updating common component template fails with field limit error', async () => {
Expand Down
Loading