-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] add support for message signing without encryption key #152624
Conversation
* generates key pair for message signing even if encryption key is not configured * private key passphrase is stored in plain text if no encryption key is configured * passphrase will be automatically encrypted if encryption key is added after key pair is generated * logs a warning if encryption key is not configured * additional unit tests
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the sign method of the message signing service be updated to to use passphrase_plain
when there is no encryption key?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Summary
adds support for using
MessageSigningService
even if encryption key is not configured:implements: https://github.com/elastic/security-team/issues/6052
Checklist
For maintainers