Code

[Lens] library annotation groups#152623

Code

Merged

drewdaemon merged 112 commits intoelastic:mainelastic/kibana:mainfrom drewdaemon:141054/library-annotation-groupsdrewdaemon/kibana:141054/library-annotation-groupsCopy head branch name to clipboardMay 31, 2023

+5,097-916

Commits

Commits on Feb 27, 2023

• refactor layer actions to be more flexible

  drewdaemon

  committed
  13d509b

  Copy full SHA for 13d509b

Commits on Feb 28, 2023

• merge martas work

  drewdaemon

  committed
  22fa4b5

  Copy full SHA for 22fa4b5

• saving annotation group to library

  drewdaemon

  committed
  f32c013

  Copy full SHA for f32c013

Commits on Mar 1, 2023

• unit test save action

  drewdaemon

  committed
  d398395

  Copy full SHA for d398395

• extract annotation group references for persistence

  drewdaemon

  committed
  89b38a7

  Copy full SHA for 89b38a7

Commits on Mar 2, 2023

• library annotation groups removed from lens saved object and loaded at bootstrap

  drewdaemon

  committed
  a47d143

  Copy full SHA for a47d143

• report data views used by annotation groups

  drewdaemon

  committed
  e47c17b

  Copy full SHA for e47c17b

• Merge branch 'main' of github.com:elastic/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  ad14b60

  Copy full SHA for ad14b60

• support by-ref annotation groups in embeddable

  drewdaemon

  committed
  968cb74

  Copy full SHA for 968cb74

• improve saved object reference names and schema

  drewdaemon

  committed
  c27a6a3

  Copy full SHA for c27a6a3

• reverting a few name changes

  drewdaemon

  committed
  568b89c

  Copy full SHA for 568b89c

Commits on Mar 3, 2023

• show saved title in layer panel header

  drewdaemon

  committed
  10bb53d

  Copy full SHA for 10bb53d

Commits on Mar 7, 2023

• save annotations in modal instead of flyout

  drewdaemon

  committed
  3a87ab7

  Copy full SHA for 3a87ab7

• Merge branch 'main' of github.com:elastic/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  26aff6f

  Copy full SHA for 26aff6f

Commits on Mar 8, 2023

• functional test: saving an annotation group

  drewdaemon

  committed
  dd6ef59

  Copy full SHA for dd6ef59

• better abstractions in the save action modal setup

  drewdaemon

  committed
  b47030c

  Copy full SHA for b47030c

• updating and copying existing annotation group

  drewdaemon

  committed
  b6c7c02

  Copy full SHA for b6c7c02

Commits on Mar 9, 2023

• improve object type message

  drewdaemon

  committed
  45c6ca2

  Copy full SHA for 45c6ca2

• simplifying annotation layer actions logic

  drewdaemon

  committed
  eb4ba12

  Copy full SHA for eb4ba12

Commits on Mar 10, 2023

• introduce linked by-value annotation layers

  drewdaemon

  committed
  685645d

  Copy full SHA for 685645d

• more accurate typings

  drewdaemon

  committed
  b10e5a7

  Copy full SHA for b10e5a7

• leave functional testing note

  drewdaemon

  committed
  ec2f544

  Copy full SHA for ec2f544

• Merge branch 'main' of github.com:elastic/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  32af469

  Copy full SHA for 32af469

• refactor components to use SavedObjectsFinder

  drewdaemon

  committed
  899f6ee

  Copy full SHA for 899f6ee

Commits on Mar 20, 2023

• Merge branch 'main' of github.com:elastic/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  c1964ad

  Copy full SHA for c1964ad

• add missing type refs

  drewdaemon

  committed
  8c4abb8

  Copy full SHA for 8c4abb8

• add existing annotation groups from library

  drewdaemon

  committed
  d18c833

  Copy full SHA for d18c833

Commits on Mar 21, 2023

• add append annotation layer unit tests

  drewdaemon

  committed
  f149af6

  Copy full SHA for f149af6

• functional test for add from library

  drewdaemon

  committed
  8f0cb7c

  Copy full SHA for 8f0cb7c

• unlink action

  drewdaemon

  committed
  9c37ce4

  Copy full SHA for 9c37ce4

Commits on Mar 22, 2023

• revert action

  drewdaemon

  committed
  15d8ec7

  Copy full SHA for 15d8ec7

• fix extra annotation group bug

  drewdaemon

  committed
  130777a

  Copy full SHA for 130777a

• fix some type errors

  drewdaemon

  committed
  2d3fda8

  Copy full SHA for 2d3fda8

Commits on Mar 23, 2023

• remove annotation layers if library group has been deleted

  drewdaemon

  committed
  d02132d

  Copy full SHA for d02132d

• Merge branch 'main' of github.com:elastic/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  c2f1b78

  Copy full SHA for c2f1b78

• Add missing group functional test

  drewdaemon

  committed
  ae5486c

  Copy full SHA for ae5486c

Commits on Mar 24, 2023

• warn users only when they're discarding annotation changes

  drewdaemon

  committed
  0abb991

  Copy full SHA for 0abb991

Commits on Mar 29, 2023

• support saving and loading groups with ad-hoc data views

  drewdaemon

  committed
  1e80420

  Copy full SHA for 1e80420

• add ad-hoc data view to lens when annotation group added

  drewdaemon

  committed
  7778006

  Copy full SHA for 7778006

• fix some types

  drewdaemon

  committed
  ffd9a1d

  Copy full SHA for ffd9a1d

Commits on Apr 3, 2023

• Merge branch 'main' of github.com:elastic/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  0a16665

  Copy full SHA for 0a16665

Commits on Apr 17, 2023

• Merge branch 'main' of github.com:elastic/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  6148054

  Copy full SHA for 6148054

Commits on Apr 19, 2023

• restore table list to main state

  drewdaemon

  committed
  f2ce71a

  Copy full SHA for f2ce71a

• Merge branch 'main' of github.com:elastic/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  a084c44

  Copy full SHA for a084c44

Commits on Apr 25, 2023

• Merge branch 'main' of github.com:elastic/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  b5e0638

  Copy full SHA for b5e0638

Commits on Apr 27, 2023

• Merge branch 'main' of github.com:elastic/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  f59f517

  Copy full SHA for f59f517

Commits on May 15, 2023

• Merge branch '141054/library-annotation-groups' of github.com:drewdaemon/kibana; branch 'main' of github.com:elastic/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  baf870a

  Copy full SHA for baf870a

• remove superfluous hide parameter

  drewdaemon

  committed
  5e66b99

  Copy full SHA for 5e66b99

• remove simpleView parameter from everywhere outside expression generation

  drewdaemon

  committed
  6770eab

  Copy full SHA for 6770eab

• Merge branch 'main' into 141054/library-annotation-groups

  kibanamachine

  authored
  5450241

  Copy full SHA for 5450241

• [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --fix'

  kibanamachine

  committed
  ecb1a2f

  Copy full SHA for ecb1a2f

• put annotation groups in the analytics index

  drewdaemon

  committed
  ca19a55

  Copy full SHA for ca19a55

• Merge branch '141054/library-annotation-groups' of github.com:drewdaemon/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  63b95ea

  Copy full SHA for 63b95ea

• [CI] Auto-commit changed files from 'node scripts/check_mappings_update --fix'

  kibanamachine

  committed
  1cb7fb3

  Copy full SHA for 1cb7fb3

Commits on May 16, 2023

• Merge branch '141054/library-annotation-groups' of github.com:drewdaemon/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  cded3e9

  Copy full SHA for cded3e9

• [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --fix'

  kibanamachine

  committed
  8a28c3d

  Copy full SHA for 8a28c3d

• fix linting problem

  drewdaemon

  committed
  78f89d1

  Copy full SHA for 78f89d1

• fix config panel test

  drewdaemon

  committed
  3cad5f6

  Copy full SHA for 3cad5f6

• Merge branch '141054/library-annotation-groups' of github.com:drewdaemon/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  e73de35

  Copy full SHA for e73de35

• limit

  drewdaemon

  committed
  d8bade5

  Copy full SHA for d8bade5

• update integration test snapshot

  drewdaemon

  committed
  4cec332

  Copy full SHA for 4cec332

• remove event annotation saved object type

  drewdaemon

  committed
  8be8e92

  Copy full SHA for 8be8e92

• update snapshot

  drewdaemon

  committed
  831e519

  Copy full SHA for 831e519

Commits on May 18, 2023

• clean up flyout

  drewdaemon

  committed
  c0f7b67

  Copy full SHA for c0f7b67

• logical improvement

  drewdaemon

  committed
  c78559e

  Copy full SHA for c78559e

• [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --fix'

  kibanamachine

  committed
  59e9823

  Copy full SHA for 59e9823

Commits on May 22, 2023

• removing unnecessary initialize parameter

  drewdaemon

  committed
  2097012

  Copy full SHA for 2097012

• Merge branch '141054/library-annotation-groups' of github.com:drewdaemon/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  33e95c3

  Copy full SHA for 33e95c3

• Merge branch 'main' of github.com:elastic/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  d21c380

  Copy full SHA for d21c380

• clean up some comments and improve some imports

  drewdaemon

  committed
  b379a9f

  Copy full SHA for b379a9f

• remove ignore global filters action

  drewdaemon

  committed
  5321a62

  Copy full SHA for 5321a62

• a couple of small logical changes

  drewdaemon

  committed
  8d436eb

  Copy full SHA for 8d436eb

• change icon

  drewdaemon

  committed
  0b52e1d

  Copy full SHA for 0b52e1d

Commits on May 23, 2023

• use changeIndexPattern action to load new ad-hoc data view

  drewdaemon

  committed
  729b593

  Copy full SHA for 729b593

• always ensure index pattern is loaded before adding library annotation layer

  drewdaemon

  committed
  3b493c6

  Copy full SHA for 3b493c6

• save index pattern references for linked layers

  drewdaemon

  committed
  302d329

  Copy full SHA for 302d329

• use flag icon for saved objects management

  drewdaemon

  committed
  5f9f3b4

  Copy full SHA for 5f9f3b4

Commits on May 24, 2023

• fix dirty state bug, clean up addLayer

  drewdaemon

  committed
  dc1ed29

  Copy full SHA for dc1ed29

Commits on May 25, 2023

• fix extra dimension bug

  drewdaemon

  committed
  7e9a62b

  Copy full SHA for 7e9a62b

• remove unused translations

  drewdaemon

  committed
  07083cb

  Copy full SHA for 07083cb

• Merge branch 'main' of github.com:elastic/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  889cc7a

  Copy full SHA for 889cc7a

• dont assume index-pattern reference when by-ref annotation layer

  drewdaemon

  committed
  0cb229c

  Copy full SHA for 0cb229c

• a little extra error handling protection

  drewdaemon

  committed
  38955ff

  Copy full SHA for 38955ff

• don't show search interface when no library groups

  drewdaemon

  committed
  3d621ab

  Copy full SHA for 3d621ab

• disable, don't hide, revert changes action

  drewdaemon

  committed
  39e38c8

  Copy full SHA for 39e38c8

• add body to the revert confirmation toast

  drewdaemon

  committed
  10d1fea

  Copy full SHA for 10d1fea

• Change confirmation modal widths

  drewdaemon

  committed
  2d825ed

  Copy full SHA for 2d825ed

• unsaved changes indicator

  drewdaemon

  committed
  230e6db

  Copy full SHA for 230e6db

• Update x-pack/plugins/lens/public/visualizations/xy/add_layer.tsx

  Show description for 8947971
  

  drewdaemon

  and

  MichaelMarcialis

  authored
  8947971

  Copy full SHA for 8947971

• Update x-pack/plugins/lens/public/visualizations/xy/annotations/actions/save_action.tsx

  Show description for 246cd01
  

  drewdaemon

  and

  MichaelMarcialis

  authored
  246cd01

  Copy full SHA for 246cd01

• impose ordering on layer actions

  drewdaemon

  committed
  37a77a4

  Copy full SHA for 37a77a4

• show save action outside context menu

  drewdaemon

  committed
  00c7370

  Copy full SHA for 00c7370

• Merge branch '141054/library-annotation-groups' of github.com:drewdaemon/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  d7d9517

  Copy full SHA for d7d9517

• update snapshot

  drewdaemon

  committed
  04f92d6

  Copy full SHA for 04f92d6

Commits on May 26, 2023

• update snapshot

  drewdaemon

  committed
  8744114

  Copy full SHA for 8744114

• some code style feedback

  drewdaemon

  committed
  3dc6ced

  Copy full SHA for 3dc6ced

• Update x-pack/plugins/lens/public/editor_frame_service/editor_frame/state_helpers.ts

  Show description for 766a3d7
  

  drewdaemon

  and

  dej611

  authored
  766a3d7

  Copy full SHA for 766a3d7

• Update x-pack/plugins/lens/public/editor_frame_service/editor_frame/state_helpers.ts

  Show description for 23566c9
  

  drewdaemon

  and

  dej611

  authored
  23566c9

  Copy full SHA for 23566c9

• [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

  kibanamachine

  committed
  7fb46cf

  Copy full SHA for 7fb46cf

• fix action ordering

  drewdaemon

  committed
  2823824

  Copy full SHA for 2823824

• Merge branch '141054/library-annotation-groups' of github.com:drewdaemon/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  d278eb0

  Copy full SHA for d278eb0

• fix library annotation loading

  drewdaemon

  committed
  63d9b3a

  Copy full SHA for 63d9b3a

• update size and format of save modal

  drewdaemon

  committed
  9df5131

  Copy full SHA for 9df5131

• hold off on validation until submit has been attempted

  drewdaemon

  committed
  60f1956

  Copy full SHA for 60f1956

• change save modal copy

  drewdaemon

  committed
  5e7814a

  Copy full SHA for 5e7814a

• marking optional fields optional

  drewdaemon

  committed
  f8cdd41

  Copy full SHA for f8cdd41

Commits on May 29, 2023

• Merge branch 'main' into 141054/library-annotation-groups

  stratoula

  authored
  3a3b53d

  Copy full SHA for 3a3b53d

• Fix CI

  stratoula

  committed
  e223128

  Copy full SHA for e223128

Commits on May 30, 2023

• new annotation from empty annotation library

  drewdaemon

  committed
  91c2db4

  Copy full SHA for 91c2db4

• Merge branch '141054/library-annotation-groups' of github.com:drewdaemon/kibana into 141054/library-annotation-groups

  drewdaemon

  committed
  9b23bef

  Copy full SHA for 9b23bef

Commits on May 31, 2023

• make unsaved changes indicator accessible

  drewdaemon

  committed
  7e53a71

  Copy full SHA for 7e53a71

• Merge branch 'main' into 141054/library-annotation-groups

  kibanamachine

  authored
  5f3be56

  Copy full SHA for 5f3be56