-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Exceptions] - Fix bug allowing user to type in custom field option for endpoint exception #152619
Conversation
Pinging @elastic/security-solution (Team: SecuritySolution) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @yctercero |
…stom field option for endpoint exception (elastic#152619) ## Summary Addresses elastic#149814 (cherry picked from commit 586f9a1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… in custom field option for endpoint exception (#152619) (#152882) # Backport This will backport the following commits from `main` to `8.7`: - [[Security Solution][Exceptions] - Fix bug allowing user to type in custom field option for endpoint exception (#152619)](#152619) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yara Tercero","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-08T08:32:16Z","message":"[Security Solution][Exceptions] - Fix bug allowing user to type in custom field option for endpoint exception (#152619)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/149814","sha":"586f9a14613ce2f22836affe4c1f6c56181e6836","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team: SecuritySolution","Feature:Rule Exceptions","Team:Security Solution Platform","backport:prev-minor","v8.7.0","v8.8.0"],"number":152619,"url":"https://github.com/elastic/kibana/pull/152619","mergeCommit":{"message":"[Security Solution][Exceptions] - Fix bug allowing user to type in custom field option for endpoint exception (#152619)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/149814","sha":"586f9a14613ce2f22836affe4c1f6c56181e6836"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152619","number":152619,"mergeCommit":{"message":"[Security Solution][Exceptions] - Fix bug allowing user to type in custom field option for endpoint exception (#152619)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/149814","sha":"586f9a14613ce2f22836affe4c1f6c56181e6836"}}]}] BACKPORT--> Co-authored-by: Yara Tercero <[email protected]>
…stom field option for endpoint exception (elastic#152619) ## Summary Addresses elastic#149814
Summary
Addresses #149814
Custom field options for exceptions were introduced with the 8.6 exception updates. This option was meant for non-endpoint exceptions. In the UI, endpoint exceptions should continue to only allow user to select from allowlisted fields.
There are and were no changes to the API, so the API remains open to accepting custom values for both types of exceptions.
Fixed
non_endpoint.mov
bug_fix_endpoint.mov
Checklist