Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] removed orphaned code #152196

Merged
merged 1 commit into from
Mar 2, 2023
Merged

[ML] removed orphaned code #152196

merged 1 commit into from
Mar 2, 2023

Conversation

walterra
Copy link
Contributor

Summary

Part of #136182.

Removes client side getTimeFieldRange() code within the data visualizer plugin. The code has been moved to the date picker package in x-pack/packages/ml/date_picker/src/services/time_field_range.tsand the duplicate is no longer necessary.

Checklist

@walterra walterra self-assigned this Feb 27, 2023
@walterra walterra mentioned this pull request Feb 27, 2023
Open
20 tasks
@walterra walterra force-pushed the 136182-ml-get-time-field-range branch from bd56cd2 to 90be173 Compare February 27, 2023 13:01
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 506 508 +2

History

  • 💔 Build #110601 failed bd56cd2cd16e8bc1dc2e19ccdb66362f3bd2865a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra added non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.8.0 :ml and removed non-issue Indicates to automation that a pull request should not appear in the release notes labels Mar 1, 2023
@walterra walterra marked this pull request as ready for review March 1, 2023 08:53
@walterra walterra requested a review from a team as a code owner March 1, 2023 08:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra requested review from darnautov and qn895 March 1, 2023 08:54
@qn895
Copy link
Member

qn895 commented Mar 1, 2023

LGMT 🎉

@walterra walterra merged commit b3c3461 into elastic:main Mar 2, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 2, 2023
@walterra walterra deleted the 136182-ml-get-time-field-range branch March 2, 2023 07:37
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@walterra @bmorelli25
[ML] removed orphaned code (elastic#152196)
245ecaa 
Removes client side `getTimeFieldRange()` code within the data
visualizer plugin. The code has been moved to the date picker package in
`x-pack/packages/ml/date_picker/src/services/time_field_range.ts`and the
duplicate is no longer necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@qn895 qn895 qn895 approved these changes

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @kibana-ci @elasticmachine @qn895 @darnautov @kibanamachine