-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] always retain source order for multi-metric partition chart layers #151949
[Lens] always retain source order for multi-metric partition chart layers #151949
Conversation
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wrong, this is how it works in main too. It works differently that agg based, this is why I was confused. Fix LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM
Summary
Fix #151006
This PR includes two changes
When users upgrade, they will see the partitions in their multi-metric charts reorder if the dimensions were out of order with the datasource. That seems fine to me since they can just drag the dimensions into the configuration they had before if they notice/care.
Screen.Recording.2023-02-23.at.2.05.41.PM.mov
Checklist