Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiling: update copy in setup button #151828

Merged

Conversation

inge4pres
Copy link
Contributor

@inge4pres inge4pres commented Feb 22, 2023

Summary

Small update to copy in the Universal Profiling button, as mentioned in https://github.com/elastic/universal-profiling-documentation/pull/29#discussion_r1113257503

@inge4pres inge4pres requested a review from a team as a code owner February 22, 2023 09:11
@inge4pres inge4pres self-assigned this Feb 22, 2023
@inge4pres inge4pres added the release_note:skip Skip the PR/issue when compiling release notes label Feb 22, 2023
Copy link
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 259.2KB 259.2KB +1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @inge4pres

@inge4pres inge4pres merged commit 26bd714 into elastic:main Feb 22, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2023
Small update to copy in the Universal Profiling button.

Signed-off-by: inge4pres <[email protected]>
(cherry picked from commit 26bd714)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 22, 2023
# Backport

This will backport the following commits from `main` to `8.7`:
- [profiling: update copy in setup button
(#151828)](#151828)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Gualazzi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-22T10:23:39Z","message":"profiling:
update copy in setup button (#151828)\n\nSmall update to copy in the
Universal Profiling button.\r\n\r\nSigned-off-by: inge4pres
<[email protected]>","sha":"26bd714af81916fff7ae7a909f7326e4a6652973","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","8.7
candidate","v8.7.0","v8.8.0"],"number":151828,"url":"https://github.com/elastic/kibana/pull/151828","mergeCommit":{"message":"profiling:
update copy in setup button (#151828)\n\nSmall update to copy in the
Universal Profiling button.\r\n\r\nSigned-off-by: inge4pres
<[email protected]>","sha":"26bd714af81916fff7ae7a909f7326e4a6652973"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151828","number":151828,"mergeCommit":{"message":"profiling:
update copy in setup button (#151828)\n\nSmall update to copy in the
Universal Profiling button.\r\n\r\nSigned-off-by: inge4pres
<[email protected]>","sha":"26bd714af81916fff7ae7a909f7326e4a6652973"}}]}]
BACKPORT-->

Co-authored-by: Francesco Gualazzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.7 candidate release_note:skip Skip the PR/issue when compiling release notes v8.7.0 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants