[RAM] Cases bulk actions & column improvements #151761

cnasikas · 2023-02-21T17:25:29Z

Summary

This PR:

Moves the case bulk actions from the solutions to the alert table
Refetch when using the case row actions & the case bulk actions.
Renames the kibana.alert.case_ids label to Cases
Unskip the alerts_table.test.tsx test file and skip the individual flaky tests. I run the test file 60 times in the CI without any issues (9efed89)
Renames the cases flyout and modal hook from get* to use*

Fixes: #151688

Userflow

Testing

Alerts table

The alerts table does not show the Cases column by default
You can choose the case column from the fields modal. Type Case to find the cases column
The label of the column is Cases
The label of the field in the fields modal is Cases
You can bulk attach alerts to a new case
You can bulk attach alerts to an existing case
When bulk attaching alerts to a case the alerts table re-fetches the data
When attaching an alert to a case from the row actions the alerts table re-fetches the data

Case integrations outside the alerts table

Ensure that you can attach your data to a case (existing and new)

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

cnasikas · 2023-02-23T10:09:46Z

x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/types.ts

+  close: () => void;
+};
+
+export interface CasesService {


When a case package is created these types will be imported from the package.

cnasikas · 2023-03-01T16:29:10Z

x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/index.mock.ts

@@ -0,0 +1,35 @@
+/*


I created an issue to create a package with Cases mocks to remove this file and import the Case UI Service mock from the package.

cnasikas · 2023-03-28T08:00:47Z

@elasticmachine merge upstream

tonyghiani

LGTM, tested locally and works fine!

cnasikas · 2023-03-28T09:04:34Z

@elasticmachine merge upstream

cnasikas · 2023-03-28T12:37:27Z

@elasticmachine merge upstream

…column

cnasikas · 2023-03-28T15:50:05Z

@elasticmachine merge upstream

cnasikas · 2023-03-28T20:36:54Z

@elasticmachine merge upstream

cnasikas · 2023-03-29T07:18:36Z

@elasticmachine merge upstream

cnasikas · 2023-03-29T16:05:42Z

@elasticmachine merge upstream

patrykkopycinski · 2023-03-29T16:06:29Z

@elasticmachine run elasticsearch-ci/docs

kibana-ci · 2023-03-29T17:45:19Z

💛 Build succeeded, but was flaky

Failed CI Steps

Threat Intelligence Tests #4

Test Failures

[job] [logs] Threat Intelligence Tests #4 / Indicators Indicator page search should narrow the results to url indicators when respective KQL search is executed

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`observability`	515	514	-1
`securitySolution`	3799	3798	-1
total			-2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	363.7KB	363.7KB	-16.0B
`infra`	1.4MB	1.4MB	-233.0B
`ml`	3.4MB	3.4MB	-6.0B
`observability`	1.1MB	1.1MB	-1.4KB
`osquery`	1.1MB	1.1MB	-5.0B
`securitySolution`	15.8MB	15.8MB	-673.0B
`threatIntelligence`	52.3KB	52.3KB	-10.0B
`triggersActionsUi`	1.4MB	1.4MB	+2.2KB
total			-101.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`cases`	30	31	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cases`	133.3KB	133.3KB	-12.0B
`triggersActionsUi`	83.6KB	83.6KB	-37.0B
total			-49.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`securitySolution`	433	435	+2

Total ESLint disabled count

id	before	after	diff
`securitySolution`	513	515	+2

History

💚 Build #116392 succeeded 78ca0ce
💔 Build #116296 failed 49cd3ce
💔 Build #116240 failed 9835e1a
💔 Build #116154 failed 6bd1bca
💔 Build #116118 failed ddef6ff
💔 Build #116027 failed ebe99a2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

## Summary This PR: - Moves the case bulk actions from the solutions to the alert table - Refetch when using the case row actions & the case bulk actions. - Renames the `kibana.alert.case_ids` label to `Cases` - Unskip the `alerts_table.test.tsx` test file and skip the individual flaky tests. I run the test file 60 times in the CI without any issues (elastic@9efed89) - Renames the cases flyout and modal hook from `get*` to `use*` Fixes: elastic#151688 ## Userflow ## Testing ### Alerts table - The alerts table does not show the Cases column by default - You can choose the case column from the fields modal. Type `Case` to find the cases column - The label of the column is `Cases` - The label of the field in the fields modal is `Cases` - You can bulk attach alerts to a new case - You can bulk attach alerts to an existing case - When bulk attaching alerts to a case the alerts table re-fetches the data - When attaching an alert to a case from the row actions the alerts table re-fetches the data ### Case integrations outside the alerts table - Ensure that you can attach your data to a case (existing and new) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <[email protected]>

cnasikas added 4 commits February 21, 2023 13:09

Rename the Cases column label

17156bc

Change Cases fields label

9b1ad7e

Disable sorting on the cases column

b747603

Improve loading

18e3eab

cnasikas added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.8.0 labels Feb 21, 2023

cnasikas self-assigned this Feb 21, 2023

cnasikas added 3 commits February 22, 2023 10:25

Create case system bulk actions

3bd0d9c

Remove case bulk actions from o11y

30364d1

Remove case context from o11y

95d960a

cnasikas changed the title ~~[RAM] Cases column improvements~~ [RAM] Cases bulk actions & column improvements Feb 22, 2023

cnasikas added 2 commits February 22, 2023 19:44

Merge branch 'main' into cases_column

392d713

Remove case bulk actions from security solution

794081d

cnasikas force-pushed the cases_column branch from 923b2f5 to 794081d Compare February 23, 2023 09:25

cnasikas commented Feb 23, 2023

View reviewed changes

cnasikas added 4 commits February 23, 2023 14:23

Remove useGetUserCasesPermissions

615b181

Refresh after attaching an alert to a case

293b03e

Merge branch 'main' into cases_column

fd01585

Refetch alerts when attaching an alert to a case

93ca5c4

cnasikas force-pushed the cases_column branch from aa500ac to 93ca5c4 Compare March 1, 2023 09:17

cnasikas added 2 commits March 1, 2023 11:44

Fix types

fe3a415

Add tests

ca13e3e

cnasikas mentioned this pull request Mar 1, 2023

[Cases] Create package for mocks #152471

Open

cnasikas commented Mar 1, 2023

View reviewed changes

cnasikas added 4 commits March 1, 2023 19:26

Fix types

1c60efb

Skip flaky test

cc612d6

Run test 100 times on CI

de11ba5

Merge branch 'main' into cases_column

ac58b9a

cnasikas removed request for ashokaditya and joeypoon March 27, 2023 15:35

Fix test

00f66b2

cnasikas requested a review from a team March 27, 2023 15:41

Merge branch 'main' into cases_column

27e2e0e

tonyghiani approved these changes Mar 28, 2023

View reviewed changes

cnasikas enabled auto-merge (squash) March 28, 2023 09:04

Merge branch 'main' into cases_column

4bdba9a

kibanamachine and others added 3 commits March 28, 2023 08:37

Merge branch 'main' into cases_column

ebe99a2

Skip flaky tests

9884670

Merge branch 'cases_column' of github.com:cnasikas/kibana into cases_…

ddef6ff

…column

Merge branch 'main' into cases_column

6bd1bca

Merge branch 'main' into cases_column

9835e1a

kibanamachine and others added 3 commits March 29, 2023 03:18

Merge branch 'main' into cases_column

49cd3ce

fix osquery cypress

73d1ca9

osquery e2e selector fix

78ca0ce

Merge branch 'main' into cases_column

3663886

cnasikas merged commit a47a3e1 into elastic:main Mar 29, 2023

cnasikas deleted the cases_column branch March 29, 2023 17:45

kibanamachine added the backport:skip This commit does not require backporting label Mar 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RAM] Cases bulk actions & column improvements #151761

[RAM] Cases bulk actions & column improvements #151761

cnasikas commented Feb 21, 2023 •

edited

Loading

cnasikas Feb 23, 2023

cnasikas Mar 1, 2023

cnasikas commented Mar 28, 2023

tonyghiani left a comment

cnasikas commented Mar 28, 2023

cnasikas commented Mar 28, 2023

cnasikas commented Mar 28, 2023

cnasikas commented Mar 28, 2023

cnasikas commented Mar 29, 2023

cnasikas commented Mar 29, 2023

patrykkopycinski commented Mar 29, 2023

kibana-ci commented Mar 29, 2023

ESLint disabled line counts

Total ESLint disabled count

[RAM] Cases bulk actions & column improvements #151761

[RAM] Cases bulk actions & column improvements #151761

Conversation

cnasikas commented Feb 21, 2023 • edited Loading

Summary

Userflow

Testing

Alerts table

Case integrations outside the alerts table

Checklist

For maintainers

cnasikas Feb 23, 2023

Choose a reason for hiding this comment

cnasikas Mar 1, 2023

Choose a reason for hiding this comment

cnasikas commented Mar 28, 2023

tonyghiani left a comment

Choose a reason for hiding this comment

cnasikas commented Mar 28, 2023

cnasikas commented Mar 28, 2023

cnasikas commented Mar 28, 2023

cnasikas commented Mar 28, 2023

cnasikas commented Mar 29, 2023

cnasikas commented Mar 29, 2023

patrykkopycinski commented Mar 29, 2023

kibana-ci commented Mar 29, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Public APIs missing exports

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

cnasikas commented Feb 21, 2023 •

edited

Loading