[Logs UI] Support inline Log Views in routes #151760
Conversation
Kerry350
added
Feature:Logs UI
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
There was a problem hiding this comment.
LGTM, as you suggested I went through the pages and everything works. Thanks also for splitting and renaming the existing logViewReferenceRT into persistedLogViewReferenceRT and inlineLogViewReferenceRT, makes much more sense in terms of naming!
I'm wondering if renaming the type for the persistedLogReference to log-view-persisted would make sense to keep the naming consistent with the new log-view-inline type, but I guess this could break the existing saved objects and require a migration right?
|
Thanks for reviewing.
I pondered a similar change myself, but left it for now. It won't affect the Saved Object which is nice. The I'll hold off on any renaming here, purely because the UI work is branched off of here so it'd be nice to get it merged. We might actually be able to consider it as part of #152278. |
Very useful, thanks for clarifying :) |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @Kerry350 |
## Summary Closes elastic#151489 This is the server side portion of support for transient / inline Log Views. Alerting and ML based functionality is scoped to the persisted type only, as we won't be supporting inline Log Views in those contexts. In terms of UI, changes have been made as close to the edge / boundary to the server (e.g. where we actually make network requests) as possible. This is because the bulk of the UI changes will come in elastic#142840. ## Testing This is predominantly a type-driven refactoring (the best kind), so we should be relatively safe here (especially since inline views aren't in the UI yet). But, a quick test of each page and a high level functional test would still be good.
Summary
Closes #151489
This is the server side portion of support for transient / inline Log Views. Alerting and ML based functionality is scoped to the persisted type only, as we won't be supporting inline Log Views in those contexts.
In terms of UI, changes have been made as close to the edge / boundary to the server (e.g. where we actually make network requests) as possible. This is because the bulk of the UI changes will come in #142840.
Testing
This is predominantly a type-driven refactoring (the best kind), so we should be relatively safe here (especially since inline views aren't in the UI yet). But, a quick test of each page and a high level functional test would still be good.