[Enterprise Search] Fixes an index name inconsistency bug #151720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 22, 2023
…1720) This fixes a bug where sometimes (after creating a crawler index) we'd see some inconsistent index name usage with unexpected redirects. This was caused by the search index component not unloading properly. Removing the `prop` usage makes sure we're no longer relying on loading/unloading to set the index name. (cherry picked from commit c2f639d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 22, 2023
) (#151825) # Backport This will backport the following commits from `main` to `8.7`: - [[Enterprise Search] Fixes an index name inconsistency bug (#151720)](#151720) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-22T08:29:31Z","message":"[Enterprise Search] Fixes an index name inconsistency bug (#151720)\n\nThis fixes a bug where sometimes (after creating a crawler index) we'd\r\nsee some inconsistent index name usage with unexpected redirects. This\r\nwas caused by the search index component not unloading properly.\r\nRemoving the `prop` usage makes sure we're no longer relying on\r\nloading/unloading to set the index name.","sha":"c2f639d1691d2dfe647db19d655beec7122330f0","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.7.0","v8.8.0"],"number":151720,"url":"https://github.com/elastic/kibana/pull/151720","mergeCommit":{"message":"[Enterprise Search] Fixes an index name inconsistency bug (#151720)\n\nThis fixes a bug where sometimes (after creating a crawler index) we'd\r\nsee some inconsistent index name usage with unexpected redirects. This\r\nwas caused by the search index component not unloading properly.\r\nRemoving the `prop` usage makes sure we're no longer relying on\r\nloading/unloading to set the index name.","sha":"c2f639d1691d2dfe647db19d655beec7122330f0"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151720","number":151720,"mergeCommit":{"message":"[Enterprise Search] Fixes an index name inconsistency bug (#151720)\n\nThis fixes a bug where sometimes (after creating a crawler index) we'd\r\nsee some inconsistent index name usage with unexpected redirects. This\r\nwas caused by the search index component not unloading properly.\r\nRemoving the `prop` usage makes sure we're no longer relying on\r\nloading/unloading to set the index name.","sha":"c2f639d1691d2dfe647db19d655beec7122330f0"}}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where sometimes (after creating a crawler index) we'd see some inconsistent index name usage with unexpected redirects. This was caused by the search index component not unloading properly. Removing the
propusage makes sure we're no longer relying on loading/unloading to set the index name.