Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Usage Collection] Reuse concurrent collectors #151626

Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented Feb 20, 2023

Summary

This is part of our attempts to reduce the impact of Usage Collection in Kibana: This PR reuses the promise of an ongoing collector in case of a subsequent call comes in.

This is an extra layer of protection to the current refreshCache: false behavior. In some cases, we've seen explicit refreshCache: true calls that may overload Kibana if an expensive Usage Collector takes longer to process, and a new request comes in.

For maintainers

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc performance Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Feb 20, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo marked this pull request as ready for review February 20, 2023 16:52
@afharo afharo requested a review from a team as a code owner February 20, 2023 16:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo self-assigned this Feb 21, 2023
@afharo afharo merged commit 6682bfd into elastic:main Feb 21, 2023
@afharo afharo deleted the usage_collection/reuse-concurrent-collectors branch February 21, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Telemetry performance release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants