[APM] Display numeric labels at the top of metadata section #151575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:APM) |
sorenlouv
commented
Feb 19, 2023
| @@ -8,6 +8,5 @@ | |||
| export interface SectionDescriptor { | |||
| key: string; | |||
| label: string; | |||
| required?: boolean; | |||
There was a problem hiding this comment.
This is leftover and hasn't been used for years.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
sorenlouv
changed the title
yngrdyn
approved these changes
Feb 21, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 21, 2023
…151575) We already display `labels` at the top of metadata to make them easy to find. Recently APM Server split out numeric labels so they are located separately from string labels. This means that the following will create one numeric label `numeric_labels.time_range_duration`, and one string label `labels.app`. ```ts transaction.addLabels({ time_range_duration: 123, app: 'apm' }); ``` Right now the numeric labels section is far down on the metadata list, making it hard to find (I missed it and didn't understand what was going on).  ...  **Change in this PR** This PR moves the the `numeric_labels` to the top of Metadata, just below the `labels` section. <img width="1443" alt="image" src="https://user-images.githubusercontent.com/209966/219975299-709ab77f-8ad7-42c0-9fe5-cbcdb7393c78.png"> (cherry picked from commit 5ee2b21)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 21, 2023
…51575) (#151694) # Backport This will backport the following commits from `main` to `8.7`: - [[APM] Display numeric labels at the top of metadata section (#151575)](#151575) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-21T12:15:47Z","message":"[APM] Display numeric labels at the top of metadata section (#151575)\n\nWe already display `labels` at the top of metadata to make them easy to\r\nfind. Recently APM Server split out numeric labels so they are located\r\nseparately from string labels. This means that the following will create\r\none numeric label `numeric_labels.time_range_duration`, and one string\r\nlabel `labels.app`.\r\n\r\n```ts\r\ntransaction.addLabels({ time_range_duration: 123, app: 'apm' });\r\n```\r\n\r\nRight now the numeric labels section is far down on the metadata list,\r\nmaking it hard to find (I missed it and didn't understand what was going\r\non).\r\n\r\n\r\n\r\n...\r\n\r\n\r\n\r\n\r\n**Change in this PR**\r\nThis PR moves the the `numeric_labels` to the top of Metadata, just\r\nbelow the `labels` section.\r\n\r\n<img width=\"1443\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/209966/219975299-709ab77f-8ad7-42c0-9fe5-cbcdb7393c78.png\">","sha":"5ee2b213b602f296677dde711b74d8153950af32","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:APM","v8.7.0","v8.8.0"],"number":151575,"url":"https://github.com/elastic/kibana/pull/151575","mergeCommit":{"message":"[APM] Display numeric labels at the top of metadata section (#151575)\n\nWe already display `labels` at the top of metadata to make them easy to\r\nfind. Recently APM Server split out numeric labels so they are located\r\nseparately from string labels. This means that the following will create\r\none numeric label `numeric_labels.time_range_duration`, and one string\r\nlabel `labels.app`.\r\n\r\n```ts\r\ntransaction.addLabels({ time_range_duration: 123, app: 'apm' });\r\n```\r\n\r\nRight now the numeric labels section is far down on the metadata list,\r\nmaking it hard to find (I missed it and didn't understand what was going\r\non).\r\n\r\n\r\n\r\n...\r\n\r\n\r\n\r\n\r\n**Change in this PR**\r\nThis PR moves the the `numeric_labels` to the top of Metadata, just\r\nbelow the `labels` section.\r\n\r\n<img width=\"1443\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/209966/219975299-709ab77f-8ad7-42c0-9fe5-cbcdb7393c78.png\">","sha":"5ee2b213b602f296677dde711b74d8153950af32"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151575","number":151575,"mergeCommit":{"message":"[APM] Display numeric labels at the top of metadata section (#151575)\n\nWe already display `labels` at the top of metadata to make them easy to\r\nfind. Recently APM Server split out numeric labels so they are located\r\nseparately from string labels. This means that the following will create\r\none numeric label `numeric_labels.time_range_duration`, and one string\r\nlabel `labels.app`.\r\n\r\n```ts\r\ntransaction.addLabels({ time_range_duration: 123, app: 'apm' });\r\n```\r\n\r\nRight now the numeric labels section is far down on the metadata list,\r\nmaking it hard to find (I missed it and didn't understand what was going\r\non).\r\n\r\n\r\n\r\n...\r\n\r\n\r\n\r\n\r\n**Change in this PR**\r\nThis PR moves the the `numeric_labels` to the top of Metadata, just\r\nbelow the `labels` section.\r\n\r\n<img width=\"1443\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/209966/219975299-709ab77f-8ad7-42c0-9fe5-cbcdb7393c78.png\">","sha":"5ee2b213b602f296677dde711b74d8153950af32"}}]}] BACKPORT--> Co-authored-by: Søren Louv-Jansen <[email protected]>
\r\n\r\n\r\n**Change](https://user-images.githubusercontent.com/209966/219943397-2c9fe2fe-89be-4c9b-8007-0986ed6d4b94.png)\r\n...\r\n\r\n\r\n\r\n\r\n**Change){kind=link}
![https://user-images.githubusercontent.com/209966/219975299-709ab77f-8ad7-42c0-9fe5-cbcdb7393c78.png\">","sha":"5ee2b213b602f296677dde711b74d8153950af32","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:APM","v8.7.0","v8.8.0"],"number":151575,"url":"https://github.com/elastic/kibana/pull/151575","mergeCommit":{"message":"[APM]](https://user-images.githubusercontent.com/209966/219975299-709ab77f-8ad7-42c0-9fe5-cbcdb7393c78.png\">","sha":"5ee2b213b602f296677dde711b74d8153950af32","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:APM","v8.7.0","v8.8.0"],"number":151575,"url":"https://github.com/elastic/kibana/pull/151575","mergeCommit":{"message":"[APM]){kind=link}
![https://user-images.githubusercontent.com/209966/219975299-709ab77f-8ad7-42c0-9fe5-cbcdb7393c78.png\">","sha":"5ee2b213b602f296677dde711b74d8153950af32"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151575","number":151575,"mergeCommit":{"message":"[APM]](https://user-images.githubusercontent.com/209966/219975299-709ab77f-8ad7-42c0-9fe5-cbcdb7393c78.png\">","sha":"5ee2b213b602f296677dde711b74d8153950af32"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151575","number":151575,"mergeCommit":{"message":"[APM]){kind=link}
![https://user-images.githubusercontent.com/209966/219975299-709ab77f-8ad7-42c0-9fe5-cbcdb7393c78.png\">","sha":"5ee2b213b602f296677dde711b74d8153950af32](https://user-images.githubusercontent.com/209966/219975299-709ab77f-8ad7-42c0-9fe5-cbcdb7393c78.png\">","sha":"5ee2b213b602f296677dde711b74d8153950af32){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already display
labelsat the top of metadata to make them easy to find. Recently APM Server split out numeric labels so they are located separately from string labels. This means that the following will create one numeric labelnumeric_labels.time_range_duration, and one string labellabels.app.Right now the numeric labels section is far down on the metadata list, making it hard to find (I missed it and didn't understand what was going on).
...
Change in this PR
This PR moves the the
numeric_labelsto the top of Metadata, just below thelabelssection.