Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.7] Fix eslint rule for restricting certain lodash imports (#151023) #151495

Merged
merged 2 commits into from
Feb 17, 2023
Merged

[8.7] Fix eslint rule for restricting certain lodash imports (#151023) #151495

merged 2 commits into from
Feb 17, 2023

Conversation

watson
Copy link
Contributor

@watson watson commented Feb 16, 2023

Backport

This will backport the following commits from main to 8.7:

Questions ?

Please refer to the Backport tool documentation

Fix eslint rule for restricting certain lodash imports (elastic#151023)
321e792 
Fixes elastic#110422

TL;DR: The `lodash.set` function is unsafe and shouldn't be called.

Cause of error: If you specify multiple `no-restricted-imports` paths
for the same module, only the last path is used. Instead you need to
combine them into a single path as I've done in this PR.

This regression was introduced in elastic#100277

(cherry picked from commit fbdeffb)

# Conflicts:
#	x-pack/plugins/apm/tsconfig.json
#	x-pack/plugins/enterprise_search/tsconfig.json
#	x-pack/plugins/lens/tsconfig.json
#	x-pack/plugins/osquery/tsconfig.json
#	x-pack/plugins/security/tsconfig.json
#	x-pack/plugins/synthetics/tsconfig.json
@watson watson enabled auto-merge (squash) February 16, 2023 18:45
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Feb 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@watson watson mentioned this pull request Feb 17, 2023
Merged
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1023.6KB 1023.6KB +21.0B
cases 394.1KB 394.1KB +8.0B
lens 1.3MB 1.3MB +18.0B
osquery 1.1MB 1.1MB +11.0B
security 556.8KB 556.9KB +26.0B
securitySolution 13.8MB 13.8MB +40.0B
triggersActionsUi 759.1KB 759.1KB +18.0B
total +142.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 130.0KB 130.1KB +66.0B
lens 34.0KB 34.0KB +58.0B
osquery 50.3KB 50.4KB +58.0B
security 57.9KB 58.0KB +58.0B
triggersActionsUi 123.3KB 123.4KB +58.0B
total +298.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@watson watson merged commit 4ed6814 into elastic:8.7 Feb 17, 2023
@watson watson deleted the backport/8.7/pr-151023 branch February 17, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@watson @elasticmachine @kibana-ci