-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry] Add scalability tests for known bottlenecks #151110
Merged
afharo
merged 13 commits into
elastic:main
from
afharo:usage_collection/apply-concurrency-limits
Mar 10, 2023
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
af70df6
[Usage Collection] Apply concurrency limits
afharo a01045d
Add more load tests
afharo 824a395
Comply with eslint name casing rules
afharo 35ebbf7
Stop applying concurrency limits. We want to merge the extra tests
afharo 74f756f
Merge branch 'main' into usage_collection/apply-concurrency-limits
kibanamachine 421688a
Merge branch 'main' into usage_collection/apply-concurrency-limits
dmlemeshko 98c1f84
Increase timeout
afharo f493167
Merge branch 'main' of github.com:elastic/kibana into usage_collectio…
afharo a7e7121
Merge branch 'main' of github.com:elastic/kibana into usage_collectio…
afharo c18c9de
Adjust thresholds as per #151110
afharo f3469fd
Remove custom thresholds after `maps` collector was removed
afharo b389aa1
Merge branch 'main' of github.com:elastic/kibana into usage_collectio…
afharo 8b31884
Default thresholds are still too high
afharo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
47 changes: 47 additions & 0 deletions
47
x-pack/test/scalability/apis/api.telemetry.cluster_stats.1600_dataviews.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| { | ||
| "journeyName": "POST /api/telemetry/v2/clusters/_stats - 1600 dataviews", | ||
| "scalabilitySetup": { | ||
| "warmup": [ | ||
| { | ||
| "action": "constantUsersPerSec", | ||
| "userCount": 10, | ||
| "duration": "30s" | ||
| } | ||
| ], | ||
| "test": [ | ||
| { | ||
| "action": "rampUsersPerSec", | ||
| "minUsersCount": 10, | ||
| "maxUsersCount": 400, | ||
| "duration": "195s" | ||
| } | ||
| ], | ||
| "maxDuration": "5m" | ||
| }, | ||
| "testData": { | ||
| "esArchives": [], | ||
| "kbnArchives": [ | ||
| "x-pack/test/scalability/fixtures/kbn_archiver/1600-dataviews.json" | ||
| ] | ||
| }, | ||
| "streams": [ | ||
| { | ||
| "requests": [ | ||
| { | ||
| "http": { | ||
| "method": "POST", | ||
| "path": "/api/telemetry/v2/clusters/_stats", | ||
| "body": "{}", | ||
| "headers": { | ||
| "Cookie": "", | ||
| "Kbn-Version": "", | ||
| "Accept-Encoding": "gzip, deflate, br", | ||
| "Content-Type": "application/json" | ||
| }, | ||
| "statusCode": 200 | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
53 changes: 53 additions & 0 deletions
53
x-pack/test/scalability/apis/api.telemetry.cluster_stats.no_cache.1600_dataviews.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| { | ||
| "journeyName": "POST /api/telemetry/v2/clusters/_stats - no cache - 1600 dataviews", | ||
| "scalabilitySetup": { | ||
| "responseTimeThreshold": { | ||
| "threshold1": 1000, | ||
| "threshold2": 3000, | ||
| "threshold3": 5000 | ||
| }, | ||
| "warmup": [ | ||
| { | ||
| "action": "constantUsersPerSec", | ||
| "userCount": 1, | ||
| "duration": "30s" | ||
| } | ||
| ], | ||
| "test": [ | ||
| { | ||
| "action": "rampUsersPerSec", | ||
| "minUsersCount": 1, | ||
| "maxUsersCount": 10, | ||
| "duration": "120s" | ||
| } | ||
| ], | ||
| "maxDuration": "5m" | ||
| }, | ||
| "testData": { | ||
| "esArchives": [], | ||
| "kbnArchives": [ | ||
| "x-pack/test/scalability/fixtures/kbn_archiver/1600-dataviews.json" | ||
| ] | ||
| }, | ||
| "streams": [ | ||
| { | ||
| "requests": [ | ||
| { | ||
| "http": { | ||
| "method": "POST", | ||
| "path": "/api/telemetry/v2/clusters/_stats", | ||
| "body": "{ \"refreshCache\": true }", | ||
| "headers": { | ||
| "Cookie": "", | ||
| "Kbn-Version": "", | ||
| "Accept-Encoding": "gzip, deflate, br", | ||
| "Content-Type": "application/json" | ||
| }, | ||
| "timeout": 240000, | ||
| "statusCode": 200 | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
50 changes: 50 additions & 0 deletions
50
x-pack/test/scalability/apis/api.telemetry.cluster_stats.no_cache.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| { | ||
| "journeyName": "POST /api/telemetry/v2/clusters/_stats - no cache", | ||
| "scalabilitySetup": { | ||
| "responseTimeThreshold": { | ||
| "threshold1": 1000, | ||
| "threshold2": 3000, | ||
| "threshold3": 5000 | ||
| }, | ||
| "warmup": [ | ||
| { | ||
| "action": "constantUsersPerSec", | ||
| "userCount": 1, | ||
| "duration": "30s" | ||
| } | ||
| ], | ||
| "test": [ | ||
| { | ||
| "action": "rampUsersPerSec", | ||
| "minUsersCount": 1, | ||
| "maxUsersCount": 10, | ||
| "duration": "120s" | ||
| } | ||
| ], | ||
| "maxDuration": "5m" | ||
| }, | ||
| "testData": { | ||
| "esArchives": [], | ||
| "kbnArchives": [] | ||
| }, | ||
| "streams": [ | ||
| { | ||
| "requests": [ | ||
| { | ||
| "http": { | ||
| "method": "POST", | ||
| "path": "/api/telemetry/v2/clusters/_stats", | ||
| "body": "{ \"refreshCache\": true }", | ||
| "headers": { | ||
| "Cookie": "", | ||
| "Kbn-Version": "", | ||
| "Accept-Encoding": "gzip, deflate, br", | ||
| "Content-Type": "application/json" | ||
| }, | ||
| "statusCode": 200 | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on local results, I think we need to adjust threshold to track.
Not sure of response time matters here, we can increase values just to understand how many requests were completed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ to increasing the timeouts... I'm concerned about the
Connection refusedfailures, though... shouldn't those be timeouts instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timeouts increased in elastic/kibana@
98c1f84(#151110)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afharo I think this test basically kills Kibana server and that's why we see "Connection refused"
I can see multiple errors like
and
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We covered this on Zoom. The intention of this test is to show that this API is problematic in this scenario. It will help us track any improvements for different efforts that have branched off since we've identified this bottleneck.
Is it a problem to have reports that show failures?