Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change may to might in Readme #15099

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Change may to might in Readme #15099

merged 1 commit into from
Nov 21, 2017

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented Nov 21, 2017

For localization, might is a better term than may.

For localization, might is a better terms than may.
@gchaps gchaps added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. chore v6.2.0 v7.0.0 labels Nov 21, 2017
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -30,7 +30,7 @@ If you want to use a Kibana release in production, give it a test run, or just p

### Building and Running Kibana, and/or Contributing Code

You may want to build Kibana locally to contribute some code, test out the latest features, or try
You might want to build Kibana locally to contribute some code, test out the latest features, or try
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow I learned something new today!

@gchaps gchaps merged commit 28a736a into elastic:master Nov 21, 2017
@gchaps gchaps deleted the Gail/test branch November 21, 2017 22:19
@dedemorton
Copy link
Contributor

Nice! is this your first official PR for Elastic? If so, congrats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.2.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants