[UA] skip system indices migration status check if featureSet.migrateSystemIndices is set to false
#150710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mIndices is set to false
Bamieh
added
release_note:skip
…-ref HEAD~1..HEAD --fix'
rudolf
added
the
bug
rudolf
approved these changes
Feb 9, 2023
alisonelizabeth
approved these changes
Feb 9, 2023
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @Bamieh |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 9, 2023
…eSystemIndices` is set to `false` (elastic#150710) Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit d2f8639)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 9, 2023
…eSystemIndices` is set to `false` (elastic#150710) Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit d2f8639)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 9, 2023
…migrateSystemIndices` is set to `false` (#150710) (#150736) # Backport This will backport the following commits from `main` to `8.6`: - [[UA] skip system indices migration status check if `featureSet.migrateSystemIndices` is set to `false` (#150710)](#150710) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ahmad Bamieh","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-09T16:09:39Z","message":"[UA] skip system indices migration status check if `featureSet.migrateSystemIndices` is set to `false` (#150710)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"d2f86398ecc76c0a8a9abdbadcb6d37a693886b9","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v8.6.2","v8.8.0"],"number":150710,"url":"https://github.com/elastic/kibana/pull/150710","mergeCommit":{"message":"[UA] skip system indices migration status check if `featureSet.migrateSystemIndices` is set to `false` (#150710)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"d2f86398ecc76c0a8a9abdbadcb6d37a693886b9"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150710","number":150710,"mergeCommit":{"message":"[UA] skip system indices migration status check if `featureSet.migrateSystemIndices` is set to `false` (#150710)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"d2f86398ecc76c0a8a9abdbadcb6d37a693886b9"}}]}] BACKPORT--> Co-authored-by: Ahmad Bamieh <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 10, 2023
…migrateSystemIndices` is set to `false` (#150710) (#150737) # Backport This will backport the following commits from `main` to `8.7`: - [[UA] skip system indices migration status check if `featureSet.migrateSystemIndices` is set to `false` (#150710)](#150710) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ahmad Bamieh","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-09T16:09:39Z","message":"[UA] skip system indices migration status check if `featureSet.migrateSystemIndices` is set to `false` (#150710)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"d2f86398ecc76c0a8a9abdbadcb6d37a693886b9","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v8.6.2","v8.8.0"],"number":150710,"url":"https://github.com/elastic/kibana/pull/150710","mergeCommit":{"message":"[UA] skip system indices migration status check if `featureSet.migrateSystemIndices` is set to `false` (#150710)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"d2f86398ecc76c0a8a9abdbadcb6d37a693886b9"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150710","number":150710,"mergeCommit":{"message":"[UA] skip system indices migration status check if `featureSet.migrateSystemIndices` is set to `false` (#150710)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"d2f86398ecc76c0a8a9abdbadcb6d37a693886b9"}}]}] BACKPORT--> Co-authored-by: Ahmad Bamieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the UA
statusroute, we need to skip the ES system indices migration status check iffeatureSet.migrateSystemIndicesis set to
false. This flag is enabled from configs for major version stack upgrades.Ideally, ES API would work as intended for non-minor versions, but for now, we'd have to skip hitting the API from Kibana's side when we are not upgrading to a major.
Context: https://github.com/elastic/cloud/issues/112124