Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Fix some minor React errors #150700

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Feb 9, 2023

Summary

This fixes two minor React errors that were showing up in the console.

@sphilipse sphilipse requested a review from a team February 9, 2023 13:21
@sphilipse sphilipse added the release_note:skip Skip the PR/issue when compiling release notes label Feb 9, 2023
@sphilipse sphilipse enabled auto-merge (squash) February 9, 2023 13:40
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB +178.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit fc2e95c into elastic:main Feb 9, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 9, 2023
## Summary

This fixes two minor React errors that were showing up in the console.

(cherry picked from commit fc2e95c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 9, 2023
)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Enterprise Search] Fix some minor React errors
(#150700)](#150700)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-09T14:42:13Z","message":"[Enterprise
Search] Fix some minor React errors (#150700)\n\n## Summary\r\n\r\nThis
fixes two minor React errors that were showing up in the
console.","sha":"fc2e95cab167b5ac16394f5f60569934509da430","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.7.0","v8.8.0"],"number":150700,"url":"https://github.com/elastic/kibana/pull/150700","mergeCommit":{"message":"[Enterprise
Search] Fix some minor React errors (#150700)\n\n## Summary\r\n\r\nThis
fixes two minor React errors that were showing up in the
console.","sha":"fc2e95cab167b5ac16394f5f60569934509da430"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150700","number":150700,"mergeCommit":{"message":"[Enterprise
Search] Fix some minor React errors (#150700)\n\n## Summary\r\n\r\nThis
fixes two minor React errors that were showing up in the
console.","sha":"fc2e95cab167b5ac16394f5f60569934509da430"}}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.7.0 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants