Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary DocumentMigrator cleanup #150529

Merged
merged 5 commits into from
Feb 8, 2023

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Feb 8, 2023

Related to #150301

This PR tend to do some preliminary cleanup before diving into the actual implementation. I'm mostly extracting things from the (way too big and hard to read) document migrator, to increase readability, maintainability and testability (note: I did not add additional unit test for the extracted files, as I did not change the impl and as we'll be rewriting them all soon enough - it would just have been a loss of time)

  • Move the document migrator from packages/core/saved-objects/core-saved-objects-migration-server-internal/src/core to it's dedicated folder document_migrator folder
  • Extract all the bits not directly performing the document transformation (e.g building the migration map, validation, utils) to their dedicated files
  • Only moving things around. No concrete code (apart from types) was modified, to ease managing conflicts with [Saved Objects] Update document migrator not to bump core version on every migration #150443

@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.8.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 8, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet marked this pull request as ready for review February 8, 2023 11:14
@pgayvallet pgayvallet requested a review from a team as a code owner February 8, 2023 11:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet requested a review from dokmic February 8, 2023 11:17
Copy link
Contributor

@dokmic dokmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pgayvallet pgayvallet merged commit 91ff710 into elastic:main Feb 8, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.8 The branch "8.8" does not exist

Manual backport

To create the backport manually run:

node scripts/backport --pr 150529

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 9, 2023
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150529 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150529 locally

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150529 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150529 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150529 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 150529 locally

@pgayvallet pgayvallet added the backport:skip This commit does not require backporting label Dec 21, 2023
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.7.0 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants