[Maps] fixes Kibana maps shows MVT borders if the geometry border style is greater than 1 #150497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le is greater than 1
…-ref HEAD~1..HEAD --fix'
|
@elasticmachine merge upstream |
nreese
added
release_note:fix
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nickpeihl
approved these changes
Feb 9, 2023
| @@ -68,6 +69,7 @@ export function initMVTRoutes({ | |||
| }; | |||
| try { | |||
| tileRequest = getHitsTileRequest({ | |||
| buffer: 'buffer' in query ? (query.buffer as number) : 5, | |||
There was a problem hiding this comment.
Why do we use parseInt in line 139, but not here?
There was a problem hiding this comment.
Thanks for pointing this out. I have switched this to use parseInt as well.
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
Feb 9, 2023
…le is greater than 1 (#150497) Fixes #150187 PR passes buffer to kibana MVT route which passes buffer to Elasticsearch vector tile API. Buffer is set based on line width style property. <img width="600" alt="Screen Shot 2023-02-07 at 2 43 15 PM" src="https://user-images.githubusercontent.com/373691/217373279-4d72e210-31ae-48cc-997f-dc05d330028b.png"> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit f439bdc)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
that referenced
this pull request
Feb 9, 2023
…er style is greater than 1 (#150497) (#150758) # Backport This will backport the following commits from `main` to `8.7`: - [[Maps] fixes Kibana maps shows MVT borders if the geometry border style is greater than 1 (#150497)](#150497) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-09T18:07:54Z","message":"[Maps] fixes Kibana maps shows MVT borders if the geometry border style is greater than 1 (#150497)\n\nFixes https://github.com/elastic/kibana/issues/150187\r\n\r\nPR passes buffer to kibana MVT route which passes buffer to\r\nElasticsearch vector tile API. Buffer is set based on line width style\r\nproperty.\r\n\r\n<img width=\"600\" alt=\"Screen Shot 2023-02-07 at 2 43 15 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/217373279-4d72e210-31ae-48cc-997f-dc05d330028b.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"f439bdc2b3fe7caa20ff5375460cc9659c6a76db","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","auto-backport","Feature:Maps","v8.7.0","v8.8.0"],"number":150497,"url":"https://github.com/elastic/kibana/pull/150497","mergeCommit":{"message":"[Maps] fixes Kibana maps shows MVT borders if the geometry border style is greater than 1 (#150497)\n\nFixes https://github.com/elastic/kibana/issues/150187\r\n\r\nPR passes buffer to kibana MVT route which passes buffer to\r\nElasticsearch vector tile API. Buffer is set based on line width style\r\nproperty.\r\n\r\n<img width=\"600\" alt=\"Screen Shot 2023-02-07 at 2 43 15 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/217373279-4d72e210-31ae-48cc-997f-dc05d330028b.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"f439bdc2b3fe7caa20ff5375460cc9659c6a76db"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150497","number":150497,"mergeCommit":{"message":"[Maps] fixes Kibana maps shows MVT borders if the geometry border style is greater than 1 (#150497)\n\nFixes https://github.com/elastic/kibana/issues/150187\r\n\r\nPR passes buffer to kibana MVT route which passes buffer to\r\nElasticsearch vector tile API. Buffer is set based on line width style\r\nproperty.\r\n\r\n<img width=\"600\" alt=\"Screen Shot 2023-02-07 at 2 43 15 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/217373279-4d72e210-31ae-48cc-997f-dc05d330028b.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"f439bdc2b3fe7caa20ff5375460cc9659c6a76db"}}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 10, 2023
![https://user-images.githubusercontent.com/373691/217373279-4d72e210-31ae-48cc-997f-dc05d330028b.png\">\r\n\r\n---------\r\n\r\nCo-authored-by](https://user-images.githubusercontent.com/373691/217373279-4d72e210-31ae-48cc-997f-dc05d330028b.png\">\r\n\r\n---------\r\n\r\nCo-authored-by){kind=link}
* main: (115 commits) [Custom branding] Add custom logo to space selector (elastic#150284) [api-docs] 2023-02-10 Daily api_docs build (elastic#150831) [ci] build next docs in PRs when relevant files change (elastic#149991) [codeowners] allow overrides to take higher precedence (elastic#150821) [docs] Remove kibDevDocsOpsPluginDiscovery (elastic#150788) [Fleet] Fix max 20 installed integrations returned from Fleet API (elastic#150780) [maps] fix Changing resolutions on Heat map layer throws error in console (elastic#150761) fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js (elastic#150768) [Synthetics] adjust overview scrolling e2e (elastic#150774) [Security Solution] Fixes bulk close alerts from exception flyout type bug (elastic#150765) Upgrade EUI to v74.1.0 (elastic#150235) [skip ci] Fix labeling for Infrastructure UI (elastic#150571) [Enterprise Search] Move pipelines modal to flyout (elastic#150727) [Security Solution] fix flaky endpoint tests (elastic#150652) Fixes the space selector page layout (elastic#150503) [Dashboard] [Navigation] Fix mount point bug (elastic#150507) [Infrastructure UI] Track host cloud provider on table entry click (elastic#150685) [Dashboard Usability] Moves scrollbar to panel section (elastic#145628) [Maps] fixes Kibana maps shows MVT borders if the geometry border style is greater than 1 (elastic#150497) [Cloud Posture][Dashboard] dashboard re-design enhancements (elastic#150394) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150187
PR passes buffer to kibana MVT route which passes buffer to Elasticsearch vector tile API. Buffer is set based on line width style property.