Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Unskips share tests #149922

Merged
merged 1 commit into from
Feb 1, 2023
Merged

[Lens] Unskips share tests #149922

merged 1 commit into from
Feb 1, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jan 31, 2023 •
edited
Loading

Summary

Closes #149163

We have seen this before. We should use the Lens wait for chart rendering function and not the global one. This stabilizes the tests

Run 100 times https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1827

Checklist

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added failed-test A test failure on a tracked branch, potentially flaky-test release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 31, 2023
@stratoula stratoula marked this pull request as ready for review January 31, 2023 13:49
@stratoula stratoula requested a review from a team as a code owner January 31, 2023 13:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

drewdaemon
drewdaemon approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on the results of the flaky test run!

@stratoula stratoula merged commit ea69956 into elastic:main Feb 1, 2023
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this pull request Feb 6, 2023
@stratoula @kqualters-elastic
[Lens] Unskips share tests (elastic#149922)
d09f255 
## Summary

Closes elastic#149163

We have seen this before. We should use the Lens wait for chart
rendering function and not the global one. This stabilizes the tests

Run 100 times
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1827

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting failed-test A test failure on a tracked branch, potentially flaky-test Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.7.0
Projects
None yet
Milestone
No milestone
5 participants
@stratoula @kibana-ci @elasticmachine @drewdaemon @kibanamachine