[ML] Fix race condition when updating data grid row count #149518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
walterra
force-pushed
the
ml-data-grid-fix-row-count
branch
from
0617bda to
2366558
Compare
|
Pinging @elastic/ml-ui (:ml) |
|
Code LGTM 🎉 |
qn895
approved these changes
Jan 26, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
…9518) This fixes an edges case where handling the row count information (the actual count and the relation (`eq/gte`)) could trigger two independent state updates. Because of those multiple state updates the check whether to show the mini histograms by default could fail. For example updating from `count: 0, relation: eq` to `count: 10000, relation: gte` could cause an intermediate state `count: 10000, relation, eq` which would pass the check to show the mini charts. The fix here is to combine the two settings to use only one `useState()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #71231.
This fixes an edges case where handling the row count information (the actual count and the relation (
eq/gte)) could trigger two independent state updates. Because of those multiple state updates the check whether to show the mini histograms by default could fail. For example updating fromcount: 0, relation: eqtocount: 10000, relation: gtecould cause an intermediate statecount: 10000, relation, eqwhich would pass the check to show the mini charts.The fix in this PR is to combine the two settings to use only one
useState().Functional tests that would catch this bug are part of the date picker update for transforms (#149049), I'm just breaking this fix out into a separate PR for to make reviewing easier/more focused.
Checklist