Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infrastructure UI] Lens charts reload problem fix #149517

Merged
merged 4 commits into from
Jan 26, 2023
Merged

[Infrastructure UI] Lens charts reload problem fix #149517

merged 4 commits into from
Jan 26, 2023

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Jan 25, 2023 •
edited
Loading

Summary

closes #149514

This PR fixes the problem with lens charts not always reloading when a search is submitted.

How to test

Go to Infrastructure > Hosts

  • Select a relative date range of 15m from now and click on submit - should always make all lens charts reload
  • Select any absolute date and click on submit- should always make all lens charts reload

@crespocarlos crespocarlos added release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services backport:skip This commit does not require backporting v8.7.0 Feature:ObsHosts Hosts feature within Observability ci:cloud-deploy Create or update a Cloud deployment labels Jan 25, 2023
@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@crespocarlos crespocarlos marked this pull request as ready for review January 25, 2023 15:21
@crespocarlos crespocarlos requested a review from a team as a code owner January 25, 2023 15:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

tonyghiani
tonyghiani approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch on this bug!

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jan 26, 2023 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.3MB 1.3MB +54.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crespocarlos crespocarlos merged commit 7facd3b into elastic:main Jan 26, 2023
@crespocarlos crespocarlos added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Feb 1, 2023
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this pull request Feb 6, 2023
@crespocarlos @kibanamachine @kqualters-elastic
[Infrastructure UI] Lens charts reload problem fix (elastic#149517)
2695d0e 
## Summary

closes elastic#149514

This PR fixes the problem with lens charts not always reloading when a
search is submitted.

### How to test

Go to Infrastructure > Hosts
- Select a relative date range of 15m from now and click on submit -
should always make all lens charts reload
- Select any absolute date and click on submit- should always make all
lens charts reload

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyghiani tonyghiani tonyghiani approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment Feature:ObsHosts Hosts feature within Observability release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infrastructure UI] Lens charts don't refresh and sorting order problems
5 participants
@crespocarlos @elasticmachine @kibana-ci @tonyghiani @kibanamachine