Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security solution] Re-add country flag to Top Countries Table #149460

Merged
merged 1 commit into from
Jan 25, 2023
Merged

[Security solution] Re-add country flag to Top Countries Table #149460

merged 1 commit into from
Jan 25, 2023

Conversation

stephmilovic
Copy link
Contributor

Summary

The CellActions PR changed the design of the Top Countries Table (unintentionally I believe). The country name column should have the flag and full country name. Fixed by re-adding the original component.

Before

Screen Shot 2023-01-24 at 2 42 27 PM

After

Screen Shot 2023-01-24 at 2 41 55 PM

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.7.0 labels Jan 24, 2023
@stephmilovic stephmilovic requested a review from a team as a code owner January 24, 2023 21:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@stephmilovic stephmilovic mentioned this pull request Jan 24, 2023
Merged
3 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB +276.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

machadoum
machadoum approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that is my mistake! Thank you for fixing it! 🙇

@stephmilovic stephmilovic merged commit cdab97b into elastic:main Jan 25, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machadoum machadoum machadoum approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephmilovic @elasticmachine @kibana-ci @machadoum @kibanamachine