Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Sync bundled packages with Package Storage #149245

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

elasticmachine
Copy link
Contributor

@elasticmachine elasticmachine requested a review from a team as a code owner January 19, 2023 16:50
@elasticmachine elasticmachine added automation release_note:skip Skip the PR/issue when compiling release notes labels Jan 19, 2023
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpollich kpollich enabled auto-merge (squash) January 19, 2023 16:55
@terrancedejesus
Copy link
Contributor

terrancedejesus commented Jan 19, 2023

@kpollich - Does this PR auto-create anytime there is an updated EPR package that is referenced in the fleet_packages.json file on main for Kibana? I ask because I am currently updated the prebuilt security rules release process and noticed that my PR may have some redundancy that yours is already doing automatically?

Reference: #149164

Another question is the logic it does to update the fleet packages reference. Multiple Prebuilt security rule packages, both prerelease and production, will be pushed to EPR during OOB updates and Elastic stack minor releases (~8 packages at least) to be expected going back to -3 and older Kibana versions. Therefore it would probably be best to only allow this to happen for the increased semantic versions into main. For example, main has v8.7.1 and a v8.7.2-beta.1 or v8.7.2 package is available in EPR.

@kpollich
Copy link
Member

kpollich commented Jan 19, 2023

Does this PR auto-create anytime there is an updated EPR package that is referenced in the fleet_packages.json file on main for Kibana?

Yes, this is an automated PR filed from a Buildkite job (linked in the description). Any time a package is published, we compare with fleet_packages.json and generate a PR if a diff is returned.

Multiple Prebuilt security rule packages, both prerelease and production, will be pushed to EPR during OOB updates and Elastic stack minor releases (~8 packages at least) to be expected going back to -3 and older Kibana versions. Therefore it would probably be best to only allow this to happen for the increased semantic versions into main. For example, main has v8.7.1 and a v8.7.2-beta.1 or v8.7.2 package is available in EPR.

There is some logic that automates this same PR to the appropriate 8.x branch as well as main based on Kibana compatibility, I believe. @mrodm could you help confirm the behavior there?

@terrancedejesus
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpollich kpollich merged commit 30a05bd into main Jan 25, 2023
@kpollich kpollich deleted the update-bundled-packages-20230119165025 branch January 25, 2023 21:11
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants