-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stack Monitoring] implement baseline elasticsearch api tests for package and metricbeat data #149161
Conversation
This reverts commit ac463e5.
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good to see that we now use just 2 archives, instead of one per test case. I've run some tests against a cloud environment and everything works fine.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @klacabane |
…kage and metricbeat data (elastic#149161) ### Summary Part of elastic#148303 Closes elastic#146067 Closes elastic#146068 I investigated the failing tests but couldn't get to the root cause quickly enough so I took the opportunity to port the tests to the [monitoring_api_integration](https://github.com/elastic/kibana/tree/main/x-pack/test/monitoring_api_integration) suite. This reimplements all the existing tests (plus missing ones for the `ml_jobs` api) with fresh data. By using the new testing approach we can remove the archived mappings which greatly reduce execution times. ### Testing - The suite was executed against by the [flaky test runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1804) multiple times with no failures - Test data is bundled in two archives (one for metricbeat and one for package data) and can be loaded to verify their content: `node scripts/es_archiver.js load x-pack/test/monitoring_api_integration/archives/elasticsearch/single_node/(package|metricbeat) --es-url=http://elastic:changeme@localhost:9200 --kibana-url=http://elastic:changeme@localhost:5601` --------- Co-authored-by: Kibana Machine <[email protected]>
Summary
Part of #148303
Closes #146067
Closes #146068
I investigated the failing tests but couldn't get to the root cause quickly enough so I took the opportunity to port the tests to the monitoring_api_integration suite. This reimplements all the existing tests (plus missing ones for the
ml_jobs
api) with fresh data.By using the new testing approach we can remove the archived mappings which greatly reduce execution times.
Testing
node scripts/es_archiver.js load x-pack/test/monitoring_api_integration/archives/elasticsearch/single_node/(package|metricbeat) --es-url=http://elastic:changeme@localhost:9200 --kibana-url=http://elastic:changeme@localhost:5601