chore(NA): upgrades uuid to v9.0.0 #149135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
force-pushed
the
upgrade-uuid-v9
branch
from
7db84bd to
30de220
Compare
mistic
added
chore
release_note:skip
…-ref HEAD~1..HEAD --fix'
|
Pinging @elastic/kibana-operations (Team:Operations) |
botelastic
bot
added
Feature:Embedding
|
Pinging @elastic/uptime (Team:uptime) |
|
Pinging @elastic/fleet (Team:Fleet) |
|
Pinging @elastic/apm-ui (Team:APM) |
mistic
removed
Feature:Embedding
|
I'm going ahead and merge this PR due to the cost of keeping it open. This is a simple |
adcoelho
added a commit
that referenced
this pull request
Jan 25, 2023
Fixes #148084 [The uuid PR was merged](#149135) so I am removing the `draft` status here. ## Summary This PR introduces search by UUID in the Cases table. If a user puts a UUID in the search bar and presses enter the search result will now return the case with that ID. Additionally, we look for the matches of that search text in the title and description fields. See the example below: <img width="1554" alt="Screenshot 2023-01-19 at 16 06 53" src="https://user-images.githubusercontent.com/1533137/213477884-498d34c0-d4d1-405d-8d76-f077d46157aa.png"> We are searching for `733e1c40-9586-11ed-a29f-8b57be9cf211`. There are two matches because that search text matches the ID of a case and the title of another. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) ### Release notes Users can now search for Cases by ID. Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades uuid into its latest version
9.0.0.The previous default used version
v4was kept where it was previously used and places usingv1orv5are still using it.In this latest version they removed the deep import feature and as we are not using tree shaking it increased our bundles by a significant size. As such, I've moved this dependency into the
ui-shared-deps-npmbundle.