[Stack Monitoring] support entsearch package #148668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klacabane
added
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
klacabane
added
the
release_note:skip
|
@elasticmachine merge upstream |
5 tasks
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @klacabane |
crespocarlos
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
LGTM! I've tested this PR while testing elastic/integrations#4926
| @@ -190,7 +190,7 @@ export const BEATS_SYSTEM_ID = 'beats'; | |||
| * The name of the Enterprise Search System ID used to publish and look up Enterprise Search stats through the Monitoring system. | |||
| * @type {string} | |||
| */ | |||
| export const ENTERPRISE_SEARCH_SYSTEM_ID = 'enterprise_search'; | |||
| export const ENTERPRISE_SEARCH_SYSTEM_ID = 'enterprisesearch'; | |||
| @@ -47,7 +47,7 @@ export const errorsQuery = ({ | |||
| }, | |||
| { | |||
| range: { | |||
| timestamp: { | |||
| '@timestamp': { | |||
There was a problem hiding this comment.
did timestamp ever work?
There was a problem hiding this comment.
It works except for enterprisesearch (added in this change) which does not have a timestamp alias. Since every data streams/metricbeat module exposes the @timestamp ecs field it made sense to update
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
### Summary Update stack monitoring to read from data streams created by the [enterprisesearch package](elastic/integrations#4926) ### Testing - build [enterprisesearch package](elastic/integrations#4926) - start stack: `elastic-package stack up -v -d --version 8.7.0-SNAPSHOT`; make sure your image contains [this change](elastic/elastic-agent#2121) - start enterprisesearch service: `elastic-package service up -v` - install elasticsearch integration with variables - `hosts: http://host.docker.internal:9201; username: elastic; password: changeme` - install enterprisesearch integration with variables - `hosts: http://host.docker.internal:3002; username: elastic; password: changeme` - connect [local kibana](https://github.com/elastic/kibana/blob/2d893bf40b47864058065f8fd2998d63c87f65f9/x-pack/plugins/monitoring/dev_docs/how_to/work_with_packages.md#connecting-a-local-kibana) - navigate to Stack Monitoring on the local kibana, enterprise search section shows up with populated graphs --------- Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update stack monitoring to read from data streams created by the enterprisesearch package
Testing
elastic-package stack up -v -d --version 8.7.0-SNAPSHOT; make sure your image contains this changeelastic-package service up -vhosts: http://host.docker.internal:9201; username: elastic; password: changemehosts: http://host.docker.internal:3002; username: elastic; password: changeme