[Fleet] Do not allow namespace or dataset to be edited for input only package policies #148422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
added
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
hop-dev
commented
Jan 4, 2023
| @@ -20,7 +20,7 @@ const DATA_STREAM_DATASET_VAR: RegistryVarsEntry = { | |||
| type: 'text', | |||
| title: 'Dataset name', | |||
| description: | |||
| "Set the name for your dataset. Changing the dataset will send the data to a different index. You can't use `-` in the name of a dataset and only valid characters for [Elasticsearch index names](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-index_.html).\n", | |||
| "Set the name for your dataset. Once selected a dataset cannot be changed without creating a new package policy. You can't use `-` in the name of a dataset and only valid characters for [Elasticsearch index names](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-index_.html).\n", | |||
There was a problem hiding this comment.
I dont think we use the word package policy in our UIs?
There was a problem hiding this comment.
We call these integration policy on the UI.
juliaElastic
approved these changes
Jan 5, 2023
kpollich
approved these changes
Jan 5, 2023
hop-dev
force-pushed
the
145529-lock-namespace-and-dataset-input-pkgs
branch
3 times, most recently
from
4ecbac3 to
b25d3ac
Compare
Co-authored-by: Kyle Pollich <[email protected]>
hop-dev
force-pushed
the
145529-lock-namespace-and-dataset-input-pkgs
branch
from
554cee9 to
1e9a41f
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @hop-dev |
kibanamachine
added
v8.7.0
backport:skip
jennypavlova
pushed a commit
to jennypavlova/kibana
that referenced
this pull request
Jan 13, 2023
… package policies (elastic#148422) ## Summary Part of elastic#145529. Input packages will create component and index templates on package policy creation. These changes make it so that to change the namespace or dataset of an input only package the user must create a new package policy, this is because by changing these the user is sending the data to a new destination which semantically is a different policy. ❓ Question: what do we publicly call package policies? Here is the new text I have added: <img width="674" alt="Screenshot 2023-01-04 at 21 05 15" src="https://user-images.githubusercontent.com/3315046/210650968-79460ff4-dd52-47bd-beb6-a0ace608bcbb.png">
jennypavlova
pushed a commit
to jennypavlova/kibana
that referenced
this pull request
Jan 13, 2023
…put only package policies" (elastic#148734) Reverts elastic#148422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #145529.
Input packages will create component and index templates on package policy creation. These changes make it so that to change the namespace or dataset of an input only package the user must create a new package policy, this is because by changing these the user is sending the data to a new destination which semantically is a different policy.
❓ Question: what do we publicly call package policies? Here is the new text I have added: