Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@kbn/babel-register] ensure that source maps are included inline #148407

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jan 4, 2023

In #146212 the default sourceMaps config for babel register changed from both to true, which creates the source maps but does not embed them in the compiled output so that dev-tools are able to inspect them even though they are not on the filesystem.

cc @vitaliidm

@spalger spalger added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes labels Jan 4, 2023
@spalger spalger requested a review from a team as a code owner January 4, 2023 17:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit ecf18db into elastic:main Jan 4, 2023
@spalger spalger deleted the fix/babel-register-source-maps branch January 4, 2023 19:30
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants