Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Add Unhandled badge to sample summary #148406

Merged

Conversation

MiriamAparicio
Copy link
Contributor

The 'Unhandled' badge was added in a previous iteration on top of the error sample exception message, after some feedback from @boriskirov, the badge is now displayed on the error sample summary

image

@MiriamAparicio MiriamAparicio added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jan 4, 2023
@MiriamAparicio MiriamAparicio requested a review from a team as a code owner January 4, 2023 17:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@MiriamAparicio MiriamAparicio enabled auto-merge (squash) January 4, 2023 17:36
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.2MB 3.2MB -69.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MiriamAparicio MiriamAparicio merged commit b497ea9 into elastic:main Jan 4, 2023
@MiriamAparicio MiriamAparicio deleted the change-unhandled-badge-position branch January 5, 2023 08:47
@MiriamAparicio MiriamAparicio self-assigned this Feb 20, 2023
@MiriamAparicio MiriamAparicio added apm:test-plan-done Pull request that was successfully tested during the test plan and removed apm:test-plan-8.7.0 labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants