Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Posture] fix flaky findings test #148017

Merged
merged 11 commits into from
Jan 15, 2023
Merged

Conversation

orouz
Copy link
Contributor

@orouz orouz commented Dec 22, 2022

Summary

closes #147998

this PR sets a fixed package version for our FTR tests.

@orouz orouz added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.7.0 labels Dec 22, 2022
@orouz
Copy link
Contributor Author

orouz commented Jan 2, 2023

seems like a fleet issue:
68747470733a2f2f73332e616d617a6f6e6177732e636f6d2f6275696c646b6974656172746966616374732e636f6d2f65306633393730652d336137352d343632312d393139662d6536633737336532626231322f62313130366566632d626135652d346539302d613835372d3131633461383939633035

@orouz orouz force-pushed the csp_findings_flaky_test branch 2 times, most recently from a8f36be to 4442a4c Compare January 11, 2023 08:36
@orouz orouz force-pushed the csp_findings_flaky_test branch from 1de84c1 to 9f810fe Compare January 11, 2023 12:33
@orouz orouz force-pushed the csp_findings_flaky_test branch from 85fb270 to 7476d04 Compare January 11, 2023 13:41
@orouz orouz marked this pull request as ready for review January 15, 2023 09:52
@orouz orouz requested a review from a team as a code owner January 15, 2023 09:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@orouz orouz requested a review from kfirpeled January 15, 2023 09:53
Comment on lines +40 to +41
`--xpack.fleet.packages.0.name=cloud_security_posture`,
`--xpack.fleet.packages.0.version=1.0.8`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notable changes:

1 - not using fleet agent policies flag, since our UI only requires and installed package and indexed findings, we don't need that for current tests, will add when needed (was used when we had benchmark tests)
2 - using 1.0.8 because newer version for 8.7 include posture/deployment vars which fail the initial fleet setup. test would still pass, but as we're going to change those vars to be non-required anyway, i prefer bumping the package used in FTR when we do that.

Copy link
Contributor

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@orouz orouz merged commit 96e8180 into elastic:main Jan 15, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.7.0
Projects
None yet
5 participants