[Step 2][ESQL] Autocomplete part #148006
Merged
[Step 2][ESQL] Autocomplete part #148006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
force-pushed
the
esql_autocomplete
branch
2 times, most recently
from
aff9f0f to
da94ab1
Compare
alexwizp
force-pushed
the
esql_autocomplete
branch
from
70e74a8 to
ed43d31
Compare
alexwizp
force-pushed
the
esql_autocomplete
branch
from
f3b07e5 to
eb8e5eb
Compare
stratoula
reviewed
Jan 3, 2023
There was a problem hiding this comment.
@alexwizp this is soooo cool ❤️ Some comments:
- When I select a field for avg it adds this with "". Can we remove the "" because esql returns an error?
- When I select the avg can I then immediately suggest the available fields? Because now I have to type a character to see the list
stratoula
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
This works great!!
I tested it on the ESQL branch and works amazing
Can we
- Move all the monaco esql updates on a PR to target main as we already have them there and won't affect anything
- After merging in main, add the unified search changes into the feature branch
|
Last comments @alexwizp sorry!
|
|
YES! Now it works great ❤️ |
alexwizp
added a commit
that referenced
this pull request
Jan 3, 2023
## Summary Autocomplete support for ESQL lang. Initially target branch for that PR was [elastic:feature-esql](https://github.com/elastic/kibana/tree/feature-esql) but then we decided to merge it separately. This PR is as copy of #148006 ## Notes: Important: please do `yarn kbn clean & yarn kbn bootstrap` before testing. ## How to update syntax. `antlr` syntax was copied from `ES` and was slightly modified. In case if you need to update it please follow next steps: - modify `esql_parser.g4 `and/or `esql_lexer.g4` files - go to `kbn-monaco` package and execute `bazel clean & npm run build:antlr4ts:painless` - go to /painless_parser.ts file and revert the following change: <img width="478" alt="image" src="https://user-images.githubusercontent.com/20072247/209540586-bb77cad1-a6f0-42fa-9875-025bd4afbace.png"> - do `yarn kbn bootstrap`
|
@elasticmachine merge upstream |
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Autocomplete support for ESQL lang.
Notes:
Important: please do
yarn kbn clean & yarn kbn bootstrapbefore testing.How to update syntax.
antlrsyntax was copied fromESand was slightly modified. In case if you need to update it please follow next steps:esql_parser.g4and/oresql_lexer.g4fileskbn-monacopackage and executebazel clean & npm run build:antlr4ts:painlessyarn kbn bootstrapChecklist