-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Cross-Origin-Opener-Policy in default response headers #147874
Conversation
Documentation preview: |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-security (Team:Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibana-docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just a remark though, I'm surprised we don't have any FTR test suite for that area/feature. I feel like having only unit tests (especially kinda low in the chain) may not necessarily be sufficient for things like testing response headers?
There's already integration tests for response headers here: |
Part of #141780
Release notes
Include Cross-Origin-Opener-Policy in default response headers
Testing
Load Kibana; you should see Kibana respond with
Cross-Origin-Opener-Policy: same-origin
header for page loads and API requests.