Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Cross-Origin-Opener-Policy in default response headers #147874

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Dec 20, 2022

Part of #141780

Release notes

Include Cross-Origin-Opener-Policy in default response headers

Testing

Load Kibana; you should see Kibana respond with Cross-Origin-Opener-Policy: same-origin header for page loads and API requests.

@github-actions
Copy link
Contributor

Documentation preview:

@thomheymann thomheymann added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.7.0 release_note:enhancement backport:skip This commit does not require backporting labels Dec 20, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 61 67 +6
osquery 109 115 +6
securitySolution 439 445 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 70 76 +6
osquery 110 117 +7
securitySolution 515 521 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomheymann thomheymann marked this pull request as ready for review December 20, 2022 17:27
@thomheymann thomheymann requested review from a team as code owners December 20, 2022 17:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-docker

Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just a remark though, I'm surprised we don't have any FTR test suite for that area/feature. I feel like having only unit tests (especially kinda low in the chain) may not necessarily be sufficient for things like testing response headers?

@thomheymann
Copy link
Contributor Author

I feel like having only unit tests (especially kinda low in the chain) may not necessarily be sufficient for things like testing response headers?

There's already integration tests for response headers here: src/core/server/integration_tests/http/lifecycle_handlers.test.ts

@thomheymann thomheymann merged commit b184f06 into elastic:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants