Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet][RBAC v2] Add tests for fleet API changes #147611

Merged
merged 17 commits into from
Jan 3, 2023
Merged

[Fleet][RBAC v2] Add tests for fleet API changes #147611

merged 17 commits into from
Jan 3, 2023

Conversation

ashokaditya
Copy link
Member

@ashokaditya ashokaditya commented Dec 15, 2022 •
edited
Loading

Summary

Tests related to changes in /pull/145361

Checklist

@ashokaditya ashokaditya self-assigned this Dec 15, 2022
@ashokaditya ashokaditya force-pushed the task/olm-add-functional-tests-for-fleet-api-changes-5617 branch 3 times, most recently from 7c67f44 to 3f06f12 Compare December 15, 2022 15:25
@ashokaditya ashokaditya force-pushed the task/olm-add-functional-tests-for-fleet-api-changes-5617 branch 3 times, most recently from 8287404 to 5a99585 Compare December 19, 2022 13:47
@ashokaditya ashokaditya force-pushed the task/olm-add-functional-tests-for-fleet-api-changes-5617 branch from 34519c6 to ea7034f Compare December 19, 2022 15:27
@ashokaditya ashokaditya marked this pull request as ready for review December 19, 2022 15:27
@ashokaditya ashokaditya requested a review from a team as a code owner December 19, 2022 15:27
@ashokaditya ashokaditya added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint v8.7.0 labels Dec 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

juliaElastic
juliaElastic approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

paul-tavares
paul-tavares approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thank you

@ashokaditya ashokaditya force-pushed the task/olm-add-functional-tests-for-fleet-api-changes-5617 branch from 6cc715d to acd2202 Compare December 22, 2022 14:30
@ashokaditya ashokaditya force-pushed the task/olm-add-functional-tests-for-fleet-api-changes-5617 branch from acd2202 to 8ba1efe Compare December 22, 2022 14:31
@ashokaditya ashokaditya requested a review from nchaulet December 22, 2022 19:40
nchaulet
nchaulet approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashokaditya ashokaditya mentioned this pull request Jan 3, 2023
Merged
2 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@ashokaditya ashokaditya merged commit 55f6006 into elastic:main Jan 3, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 3, 2023
@ashokaditya ashokaditya deleted the task/olm-add-functional-tests-for-fleet-api-changes-5617 branch January 3, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

@nchaulet nchaulet nchaulet approved these changes

Assignees

@ashokaditya ashokaditya

Labels
backport:skip This commit does not require backporting OLM Sprint release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ashokaditya @elasticmachine @kibana-ci @nchaulet @paul-tavares @juliaElastic @kibanamachine @hop-dev