[ML] Explain Log Rate Spikes: Fix client side code to transform groups into table rows. #147592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
|
Pinging @elastic/ml-ui (:ml) |
5 tasks
peteharverson
approved these changes
Dec 16, 2022
…erra/kibana into 146162c-fix-client-side-table-items
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Dec 20, 2022
…s into table rows. (elastic#147592) Fixes client side code to transform groups into table rows. Because the transformation used a dictionary like structure with field names as keys, we missed if there were multiple values for a field. This changes the structure to an array of field/value pairs so we can support multiple values per field. (cherry picked from commit 92ffe27) # Conflicts: # x-pack/plugins/aiops/public/components/spike_analysis_table/spike_analysis_table_groups.tsx
walterra
added a commit
that referenced
this pull request
Dec 20, 2022
… groups into table rows. (#147592) (#147832) # Backport This will backport the following commits from `main` to `8.6`: - [[ML] Explain Log Rate Spikes: Fix client side code to transform groups into table rows. (#147592)](#147592) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-20T08:19:11Z","message":"[ML] Explain Log Rate Spikes: Fix client side code to transform groups into table rows. (#147592)\n\nFixes client side code to transform groups into table rows. Because the\r\ntransformation used a dictionary like structure with field names as\r\nkeys, we missed if there were multiple values for a field. This changes\r\nthe structure to an array of field/value pairs so we can support\r\nmultiple values per field.","sha":"92ffe2764f01a67658db854506bbd5003f0adcb8","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","Feature:ML/AIOps","v8.6.0","v8.7.0"],"number":147592,"url":"https://github.com/elastic/kibana/pull/147592","mergeCommit":{"message":"[ML] Explain Log Rate Spikes: Fix client side code to transform groups into table rows. (#147592)\n\nFixes client side code to transform groups into table rows. Because the\r\ntransformation used a dictionary like structure with field names as\r\nkeys, we missed if there were multiple values for a field. This changes\r\nthe structure to an array of field/value pairs so we can support\r\nmultiple values per field.","sha":"92ffe2764f01a67658db854506bbd5003f0adcb8"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147592","number":147592,"mergeCommit":{"message":"[ML] Explain Log Rate Spikes: Fix client side code to transform groups into table rows. (#147592)\n\nFixes client side code to transform groups into table rows. Because the\r\ntransformation used a dictionary like structure with field names as\r\nkeys, we missed if there were multiple values for a field. This changes\r\nthe structure to an array of field/value pairs so we can support\r\nmultiple values per field.","sha":"92ffe2764f01a67658db854506bbd5003f0adcb8"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #146162.
Fixes client side code to transform groups into table rows. Because the transformation used a dictionary like structure with field names as keys, we missed if there were multiple values for a field. This changes the structure to an array of field/value pairs so we can support multiple values per field.
Before:
After:
Checklist