Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add override for data which doesn't contain a time field #147504

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Dec 14, 2022

Adds a checkbox to the overrides flyout to allow the user to tell the find structure endpoint that the data does not contain a time field.

image

If the original analysis of the data does not find a time field, this checkbox is unchecked by default.

Closes #146700

Also removes the jest snapshot test for the override flyout as it isn't very useful.

@jgowdyelastic jgowdyelastic requested a review from a team as a code owner December 14, 2022 11:26
@jgowdyelastic jgowdyelastic self-assigned this Dec 14, 2022
@jgowdyelastic jgowdyelastic added release_note:enhancement enhancement New value added to drive a business result :ml Feature:File and Index Data Viz ML file and index data visualizer v8.7.0 labels Dec 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 532.6KB 533.3KB +671.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataVisualizer 20.4KB 20.5KB +43.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 61 67 +6
osquery 109 115 +6
securitySolution 440 446 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 70 76 +6
osquery 110 117 +7
securitySolution 517 523 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit d14bf59 into elastic:main Dec 16, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:enhancement v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Allow "no timestamp" to be specified as the timestamp format in file upload
5 participants