Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NA): remove yarn workspaces warning on bootstrap #147411

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

mistic
Copy link
Member

@mistic mistic commented Dec 13, 2022

This PR bumps the puppeteer version which was holding the workspaces key on its package.json that was causing a warning (Workspaces can only be enabled in private projects) when running yarn install at bootstrap. This key should only be present for private packages.

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.7.0 labels Dec 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 60 66 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 69 75 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic requested a review from jbudz December 13, 2022 16:24
@mistic mistic merged commit 5d74e83 into elastic:main Dec 14, 2022
nreese pushed a commit to nreese/kibana that referenced this pull request Dec 16, 2022
This PR bumps the `puppeteer` version which was holding the `workspaces`
key on its package.json that was causing a warning (`Workspaces can only
be enabled in private projects`) when running yarn install at bootstrap.
This key should only be present for private packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants