Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change file namespace type to multiple-isolated #147198

Merged
merged 4 commits into from
Dec 13, 2022
+2 −2
Merged

change file namespace type to multiple-isolated #147198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
423df69
change file namespace type to multiple-isolated
vadimkibana Dec 7, 2022
b1f660f
Merge branch 'main' into file-so-ns-type
kibanamachine Dec 12, 2022
4f9eab4
test: update so file type hash
vadimkibana Dec 12, 2022
98dc15a
Merge branch 'main' into file-so-ns-type
kibanamachine Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/server/integration_tests/saved_objects/migrations/check_registered_types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ describe('checking migration metadata changes on all registered SO types', () =>
"event_loop_delays_daily": "d2ed39cf669577d90921c176499908b4943fb7bd",
"exception-list": "fe8cc004fd2742177cdb9300f4a67689463faf9c",
"exception-list-agnostic": "49fae8fcd1967cc4be45ba2a2c66c4afbc1e341b",
"file": "05c14a75e5e20b12ca514a1d7de231f420facf2c",
"file": "f5d393602a4c103eb0ace983e6810f7f3666544b",
"file-upload-usage-collection-telemetry": "8478924cf0057bd90df737155b364f98d05420a5",
"fileShare": "3f88784b041bb8728a7f40763a08981828799a75",
"fleet-fleet-server-host": "643d15dbf56edb96f7ca65f98409d83ac5792fb6",
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/files/server/saved_objects/file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const properties: Properties = {
export const fileObjectType: SavedObjectsType<FileMetadata> = {
name: FILE_SO_TYPE,
hidden: true,
namespaceType: 'agnostic',
namespaceType: 'multiple-isolated',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the docs:

In other words, objects with a "multiple-isolated" namespace type will be share-capable

I guess that means that are not shareable right now? CC @rudolf

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. The security team has docs on what needs to be done to make a multiple-isolated saved object shareable.

management: {
importableAndExportable: false,
},
Expand Down