Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Render the sidebar even if documents fetching failed #147179

Merged
merged 4 commits into from
Dec 8, 2022

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Dec 7, 2022

This is a follow up PR for #144412 to fix how "Error" case is handled.

Before: the sidebar was stuck in loading state:
Screenshot 2022-12-07 at 13 16 21

After: the sidebar is rendered:
Screenshot 2022-12-07 at 13 17 06

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0 labels Dec 7, 2022
@jughosta jughosta self-assigned this Dec 7, 2022
@jughosta jughosta marked this pull request as ready for review December 7, 2022 13:57
@jughosta jughosta requested a review from a team as a code owner December 7, 2022 13:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 418.2KB 418.3KB +112.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and tested locally + ran functional test. LGTM, thanks for fixing!

@jughosta jughosta merged commit 1f0ae32 into elastic:main Dec 8, 2022
@jughosta jughosta deleted the error-case-show-sidebar branch December 8, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants