Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Adding security solution packages as a dependency #146561

Merged
merged 1 commit into from
Nov 30, 2022
Merged

[Security Solution] Adding security solution packages as a dependency #146561

merged 1 commit into from
Nov 30, 2022

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Nov 29, 2022 •
edited by kibanamachine
Loading

Summary

Changes in the Security Solution packages may break our application, we are adding them as a dependency to execute our Cypress tests when a change is made in order to minimise the risk of introducing new issues.

@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0 v8.7.0 labels Nov 29, 2022
@MadameSheema MadameSheema requested a review from a team as a code owner November 29, 2022 14:40
@MadameSheema MadameSheema self-assigned this Nov 29, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 442 448 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 519 525 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

YulNaumenko
YulNaumenko approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

rylnd
rylnd approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MadameSheema MadameSheema merged commit 2cb675d into elastic:main Nov 30, 2022
@MadameSheema MadameSheema deleted the cypress/security-solution-package-dependency branch November 30, 2022 14:17
@MadameSheema MadameSheema mentioned this pull request Nov 30, 2022
Closed
@MadameSheema
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Nov 30, 2022
@MadameSheema
[Security Solution] Adding security solution packages as a dependency (…
c51eb15 
…elastic#146561)

(cherry picked from commit 2cb675d)
@kibanamachine kibanamachine mentioned this pull request Nov 30, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 30, 2022
@MadameSheema
[Security Solution] Adding security solution packages as a dependency (…
58a73c9 
…elastic#146561)

(cherry picked from commit 2cb675d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 30, 2022
@kibanamachine @MadameSheema
[8.6] [Security Solution] Adding security solution packages as a depe…
bc25707 
…ndency (#146561) (#146691)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Security Solution] Adding security solution packages as a dependency
(#146561)](#146561)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gloria
Hornero","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-30T14:17:32Z","message":"[Security
Solution] Adding security solution packages as a dependency
(#146561)","sha":"2cb675d8142638f35b8e4abb6e91a0349f9f5c73","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections
and Resp","Team:Threat Hunting","Team:
SecuritySolution","v8.6.0","v8.7.0"],"number":146561,"url":"https://github.com/elastic/kibana/pull/146561","mergeCommit":{"message":"[Security
Solution] Adding security solution packages as a dependency
(#146561)","sha":"2cb675d8142638f35b8e4abb6e91a0349f9f5c73"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146561","number":146561,"mergeCommit":{"message":"[Security
Solution] Adding security solution packages as a dependency
(#146561)","sha":"2cb675d8142638f35b8e4abb6e91a0349f9f5c73"}}]}]
BACKPORT-->

Co-authored-by: Gloria Hornero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd approved these changes

@jbudz jbudz jbudz approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees

@MadameSheema MadameSheema

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MadameSheema @elasticmachine @kibana-ci @kibanamachine @rylnd @jbudz @YulNaumenko