[Synthetics] Fixes project monitor edit code path #146416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:skip
dominiqueclarke
requested changes
Nov 29, 2022
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
force-pushed
the
project-monitor-refactor
branch
from
8bf8d3c to
c05aba8
Compare
shahzad31
force-pushed
the
project-monitor-refactor
branch
from
a30236e to
728e513
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 2, 2022
## Summary Fixed project monitor editor code path, it was called un-necessarily on each request. (cherry picked from commit dc2b29a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 2, 2022
…46853) # Backport This will backport the following commits from `main` to `8.6`: - [[Synthetics] Fixes project monitor edit code path (#146416)](#146416) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-02T08:56:29Z","message":"[Synthetics] Fixes project monitor edit code path (#146416)\n\n## Summary\n\nFixed project monitor editor code path, it was called un-necessarily on\neach request.","sha":"dc2b29add974e8ab086979f11f7ff7fa8967a495","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.6.0","v8.7.0"],"number":146416,"url":"https://github.com/elastic/kibana/pull/146416","mergeCommit":{"message":"[Synthetics] Fixes project monitor edit code path (#146416)\n\n## Summary\n\nFixed project monitor editor code path, it was called un-necessarily on\neach request.","sha":"dc2b29add974e8ab086979f11f7ff7fa8967a495"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146416","number":146416,"mergeCommit":{"message":"[Synthetics] Fixes project monitor edit code path (#146416)\n\n## Summary\n\nFixed project monitor editor code path, it was called un-necessarily on\neach request.","sha":"dc2b29add974e8ab086979f11f7ff7fa8967a495"}}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed project monitor editor code path, it was called un-necessarily on each request.