Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Overview - standardize queries for monitor duration metric item #145916

Merged
merged 12 commits into from
Nov 22, 2022
Merged

[Synthetics] Overview - standardize queries for monitor duration metric item #145916

merged 12 commits into from
Nov 22, 2022

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Nov 21, 2022 •
edited by kibanamachine
Loading

Summary

Resolves #145922
Resolves #145270

Fixes a regression from #143309

Standardizes the way the monitor duration metric is queried, ensuring that both monitor types, UI and Project, are queries in the same way.

The changes were also carried into changes to the Monitor Flyout

Before (duration for UI monitor shows, but not the duration for project monitors)
image

After (duration shows for both monitor types)
Screen Shot 2022-11-21 at 2 39 09 PM

Testing

  1. Create at least one project monitor and one UI monitor
  2. Ensure that both monitor types display the duration metric on the Overview page after running
  3. In the actions popover, click edit monitor. Ensure the page redirects to the monitor edit page appropriately
  4. In the actions popover, click go to monitor. Ensure that the page redirects to the monitor details page appropriately
  5. In the actions popover, disable the monitor. Ensure it is successful.
  6. In the actions popover, click inspect. Ensure the monitor flyout appears, then close the flyout.
  7. Click on both monitor types, ensure the monitor flyout appears
  8. Ensure the monitor duration metric appears in the monitor flyout
  9. Ensure the last test run appears in the monitor flyout
  10. Ensure both enable toggles work in the monitor flyout (in the body of the flyout and actions popover next to the flyout title)
  11. Ensure the go to monitor link works in the monitor flyout actions popover next to the monitor title
  12. Ensure the edit monitor link works in the monitor flyout actions popover next to the monitor title

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.6.0 v8.7.0 labels Nov 21, 2022
@dominiqueclarke dominiqueclarke changed the title Fix/synthetics overview project monitors [Synthetics] Overview - standardize queries for monitor duration metric item Nov 21, 2022
@dominiqueclarke dominiqueclarke marked this pull request as ready for review November 21, 2022 19:41
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner November 21, 2022 19:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke requested a review from a team as a code owner November 22, 2022 00:57
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.1MB 1.1MB +238.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
synthetics 25.3KB 25.3KB -2.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id before after diff
synthetics-monitor 23 24 +1
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke mentioned this pull request Nov 22, 2022
Closed
3 tasks
@dominiqueclarke dominiqueclarke merged commit e8d77b3 into elastic:main Nov 22, 2022
@dominiqueclarke dominiqueclarke deleted the fix/synthetics-overview-project-monitors branch November 22, 2022 14:49
@kibanamachine kibanamachine mentioned this pull request Nov 22, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 22, 2022
@dominiqueclarke
[Synthetics] Overview - standardize queries for monitor duration metr…
4cf4c79 
…ic item (elastic#145916)

## Summary

Resolves elastic#145922
Resolves elastic#145270

Fixes a regression from elastic#143309

Standardizes the way the monitor duration metric is queried, ensuring
that both monitor types, UI and Project, are queries in the same way.

The changes were also carried into changes to the Monitor Flyout

Before (duration for UI monitor shows, but not the duration for project
monitors)

![image](https://user-images.githubusercontent.com/11356435/203143905-4564b14e-a2af-402c-a2c1-5b95d22ad1e3.png)

After (duration shows for both monitor types)
<img width="1366" alt="Screen Shot 2022-11-21 at 2 39 09 PM"
src="https://user-images.githubusercontent.com/11356435/203144056-d74617e5-6745-4c17-9a68-e5164f4be689.png">

### Testing
1. Create at least one project monitor and one UI monitor
2. Ensure that both monitor types display the duration metric on the
Overview page after running
3. In the actions popover, click edit monitor. Ensure the page redirects
to the monitor edit page appropriately
4. In the actions popover, click go to monitor. Ensure that the page
redirects to the monitor details page appropriately
5. In the actions popover, disable the monitor. Ensure it is successful.
6. In the actions popover, click inspect. Ensure the monitor flyout
appears, then close the flyout.
7. Click on both monitor types, ensure the monitor flyout appears
8. Ensure the monitor duration metric appears in the monitor flyout
9. Ensure the last test run appears in the monitor flyout
10. Ensure both enable toggles work in the monitor flyout (in the body
of the flyout and actions popover next to the flyout title)
11. Ensure the go to monitor link works in the monitor flyout actions
popover next to the monitor title
12. Ensure the edit monitor link works in the monitor flyout actions
popover next to the monitor title

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit e8d77b3)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 22, 2022
@kibanamachine @dominiqueclarke
[8.6] [Synthetics] Overview - standardize queries for monitor duratio…
b585760 
…n metric item (#145916) (#146005)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Synthetics] Overview - standardize queries for monitor duration
metric item (#145916)](#145916)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dominique
Clarke","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-22T14:49:07Z","message":"[Synthetics]
Overview - standardize queries for monitor duration metric item
(#145916)\n\n## Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/145922\r\nResolves
https://github.com/elastic/kibana/issues/145270\r\n\r\nFixes a
regression from
https://github.com/elastic/kibana/issues/143309\r\n\r\nStandardizes the
way the monitor duration metric is queried, ensuring\r\nthat both
monitor types, UI and Project, are queries in the same way.\r\n\r\nThe
changes were also carried into changes to the Monitor
Flyout\r\n\r\nBefore (duration for UI monitor shows, but not the
duration for
project\r\nmonitors)\r\n\r\n![image](https://user-images.githubusercontent.com/11356435/203143905-4564b14e-a2af-402c-a2c1-5b95d22ad1e3.png)\r\n\r\nAfter
(duration shows for both monitor types)\r\n<img width=\"1366\"
alt=\"Screen Shot 2022-11-21 at 2 39 09
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/203144056-d74617e5-6745-4c17-9a68-e5164f4be689.png\">\r\n\r\n###
Testing\r\n1. Create at least one project monitor and one UI
monitor\r\n2. Ensure that both monitor types display the duration metric
on the\r\nOverview page after running\r\n3. In the actions popover,
click edit monitor. Ensure the page redirects\r\nto the monitor edit
page appropriately\r\n4. In the actions popover, click go to monitor.
Ensure that the page\r\nredirects to the monitor details page
appropriately\r\n5. In the actions popover, disable the monitor. Ensure
it is successful.\r\n6. In the actions popover, click inspect. Ensure
the monitor flyout\r\nappears, then close the flyout.\r\n7. Click on
both monitor types, ensure the monitor flyout appears\r\n8. Ensure the
monitor duration metric appears in the monitor flyout\r\n9. Ensure the
last test run appears in the monitor flyout\r\n10. Ensure both enable
toggles work in the monitor flyout (in the body\r\nof the flyout and
actions popover next to the flyout title)\r\n11. Ensure the go to
monitor link works in the monitor flyout actions\r\npopover next to the
monitor title\r\n12. Ensure the edit monitor link works in the monitor
flyout actions\r\npopover next to the monitor
title\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"e8d77b3f0f46ac62e9220ffe28eb455880854906","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.6.0","v8.7.0"],"number":145916,"url":"https://github.com/elastic/kibana/pull/145916","mergeCommit":{"message":"[Synthetics]
Overview - standardize queries for monitor duration metric item
(#145916)\n\n## Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/145922\r\nResolves
https://github.com/elastic/kibana/issues/145270\r\n\r\nFixes a
regression from
https://github.com/elastic/kibana/issues/143309\r\n\r\nStandardizes the
way the monitor duration metric is queried, ensuring\r\nthat both
monitor types, UI and Project, are queries in the same way.\r\n\r\nThe
changes were also carried into changes to the Monitor
Flyout\r\n\r\nBefore (duration for UI monitor shows, but not the
duration for
project\r\nmonitors)\r\n\r\n![image](https://user-images.githubusercontent.com/11356435/203143905-4564b14e-a2af-402c-a2c1-5b95d22ad1e3.png)\r\n\r\nAfter
(duration shows for both monitor types)\r\n<img width=\"1366\"
alt=\"Screen Shot 2022-11-21 at 2 39 09
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/203144056-d74617e5-6745-4c17-9a68-e5164f4be689.png\">\r\n\r\n###
Testing\r\n1. Create at least one project monitor and one UI
monitor\r\n2. Ensure that both monitor types display the duration metric
on the\r\nOverview page after running\r\n3. In the actions popover,
click edit monitor. Ensure the page redirects\r\nto the monitor edit
page appropriately\r\n4. In the actions popover, click go to monitor.
Ensure that the page\r\nredirects to the monitor details page
appropriately\r\n5. In the actions popover, disable the monitor. Ensure
it is successful.\r\n6. In the actions popover, click inspect. Ensure
the monitor flyout\r\nappears, then close the flyout.\r\n7. Click on
both monitor types, ensure the monitor flyout appears\r\n8. Ensure the
monitor duration metric appears in the monitor flyout\r\n9. Ensure the
last test run appears in the monitor flyout\r\n10. Ensure both enable
toggles work in the monitor flyout (in the body\r\nof the flyout and
actions popover next to the flyout title)\r\n11. Ensure the go to
monitor link works in the monitor flyout actions\r\npopover next to the
monitor title\r\n12. Ensure the edit monitor link works in the monitor
flyout actions\r\npopover next to the monitor
title\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"e8d77b3f0f46ac62e9220ffe28eb455880854906"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145916","number":145916,"mergeCommit":{"message":"[Synthetics]
Overview - standardize queries for monitor duration metric item
(#145916)\n\n## Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/145922\r\nResolves
https://github.com/elastic/kibana/issues/145270\r\n\r\nFixes a
regression from
https://github.com/elastic/kibana/issues/143309\r\n\r\nStandardizes the
way the monitor duration metric is queried, ensuring\r\nthat both
monitor types, UI and Project, are queries in the same way.\r\n\r\nThe
changes were also carried into changes to the Monitor
Flyout\r\n\r\nBefore (duration for UI monitor shows, but not the
duration for
project\r\nmonitors)\r\n\r\n![image](https://user-images.githubusercontent.com/11356435/203143905-4564b14e-a2af-402c-a2c1-5b95d22ad1e3.png)\r\n\r\nAfter
(duration shows for both monitor types)\r\n<img width=\"1366\"
alt=\"Screen Shot 2022-11-21 at 2 39 09
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/203144056-d74617e5-6745-4c17-9a68-e5164f4be689.png\">\r\n\r\n###
Testing\r\n1. Create at least one project monitor and one UI
monitor\r\n2. Ensure that both monitor types display the duration metric
on the\r\nOverview page after running\r\n3. In the actions popover,
click edit monitor. Ensure the page redirects\r\nto the monitor edit
page appropriately\r\n4. In the actions popover, click go to monitor.
Ensure that the page\r\nredirects to the monitor details page
appropriately\r\n5. In the actions popover, disable the monitor. Ensure
it is successful.\r\n6. In the actions popover, click inspect. Ensure
the monitor flyout\r\nappears, then close the flyout.\r\n7. Click on
both monitor types, ensure the monitor flyout appears\r\n8. Ensure the
monitor duration metric appears in the monitor flyout\r\n9. Ensure the
last test run appears in the monitor flyout\r\n10. Ensure both enable
toggles work in the monitor flyout (in the body\r\nof the flyout and
actions popover next to the flyout title)\r\n11. Ensure the go to
monitor link works in the monitor flyout actions\r\npopover next to the
monitor title\r\n12. Ensure the edit monitor link works in the monitor
flyout actions\r\npopover next to the monitor
title\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"e8d77b3f0f46ac62e9220ffe28eb455880854906"}}]}]
BACKPORT-->

Co-authored-by: Dominique Clarke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
6 participants
@dominiqueclarke @elasticmachine @kibana-ci @kibanamachine @pgayvallet @shahzad31