Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESQL] Integration with Lens and Discover #145803

Closed
wants to merge 21 commits into from
Closed

[ESQL] Integration with Lens and Discover #145803

wants to merge 21 commits into from

Conversation

stratoula
Copy link
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

@github-actions
Copy link
Contributor

Documentation preview:

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
b861fe1, de544b8, 66d0073, 2364f7e, b0a12a7, 12a4e42

Please, read and sign the above mentioned agreement if you want to contribute to this project

@stratoula
Copy link
Contributor Author

closing in favor of #146971

@stratoula stratoula closed this Dec 5, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Dec 5, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #26 / discover/group1 discover sidebar renders field groups should show selected and available fields in text-based mode
  • [job] [logs] FTR Configs #26 / discover/group1 discover sidebar renders field groups should show selected and available fields in text-based mode
  • [job] [logs] FTR Configs #8 / lens app - group 1 lens text based language tests should navigate to text based languages mode correctly
  • [job] [logs] FTR Configs #8 / lens app - group 1 lens text based language tests should navigate to text based languages mode correctly

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 457 461 +4
unifiedSearch 172 173 +1
total +5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/es-query 170 172 +2
@kbn/monaco 55 58 +3
data 2553 2554 +1
total +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 413.7KB 413.8KB +145.0B
lens 1.3MB 1.3MB +81.0B
unifiedSearch 216.2KB 228.2KB +12.1KB
total +12.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 401.4KB 404.3KB +2.9KB
discover 27.9KB 27.9KB +13.0B
kbnUiSharedDeps-srcJs 4.1MB 4.1MB +1.6KB
lens 29.6KB 29.7KB +6.0B
unifiedSearch 50.5KB 50.6KB +58.0B
total +4.6KB
Unknown metric groups

API count

id before after diff
@kbn/es-query 227 229 +2
@kbn/monaco 55 58 +3
data 3265 3266 +1
total +6

async chunk count

id before after diff
unifiedSearch 14 15 +1

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
@kbn/monaco 3 4 +1
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +21

Total ESLint disabled count

id before after diff
@kbn/monaco 7 8 +1
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +22

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sophiec20 sophiec20 deleted the feature/esql branch July 30, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants