Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.6] [controls] fix Time Slider text is not working properly with Dark Mode (#145612) #145623

Merged
merged 1 commit into from
Nov 17, 2022
Merged

[8.6] [controls] fix Time Slider text is not working properly with Dark Mode (#145612) #145623

merged 1 commit into from
Nov 17, 2022
+13 −10

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.6:

Questions ?

Please refer to the Backport tool documentation

@nreese
[controls] fix Time Slider text is not working properly with Dark Mode (
3d02967 
#145612)

Fixes #145594

TimeSlider component is not wrapped by KibanaThemeProvider and therefore
does not properly use kibana themeing. This PR resolves the issues by
wrapping TimeSlider by KibanaThemeProvider.

To test
* set advanced setting `theme:darkMode` to true
* open dashboard
* add time slider
* verify timeslider is using dark theme

<img width="500" alt="Screen Shot 2022-11-17 at 12 04 40 PM"
src="https://user-images.githubusercontent.com/373691/202536272-9ef9e9fe-debe-4722-a50e-03929b94c18d.png">

(cherry picked from commit d5ed16a)
@kibanamachine kibanamachine enabled auto-merge (squash) November 17, 2022 20:31
@kibanamachine kibanamachine mentioned this pull request Nov 17, 2022
Merged
@kibanamachine kibanamachine merged commit 953ece5 into 8.6 Nov 17, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 474.1KB 474.2KB +85.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nreese

@kibanamachine kibanamachine deleted the backport/8.6/pr-145612 branch November 17, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nreese nreese

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @kibana-ci @nreese