Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Do not show processors and streams editor for input only pkgs #145617

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Nov 17, 2022

A temporary measure until #145414 is resolved.

Title says it all! We Don't currently create the pipelines and templates for input only packages at the moment (see #145529 ) so hiding this part if the UI.

@hop-dev hop-dev added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 17, 2022
@hop-dev hop-dev requested a review from a team as a code owner November 17, 2022 20:03
@hop-dev hop-dev self-assigned this Nov 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 I think it will resolve that issue too #144696

@hop-dev
Copy link
Contributor Author

hop-dev commented Nov 18, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 887.8KB 887.9KB +23.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 442 448 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 519 525 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@hop-dev hop-dev merged commit babfb01 into elastic:main Nov 18, 2022
@hop-dev hop-dev deleted the 145414-hide-pipelines-for-input-pkg branch November 18, 2022 11:15
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants